From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGmBc-0003uO-3T for qemu-devel@nongnu.org; Tue, 03 Sep 2013 04:42:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGmBR-00044O-O3 for qemu-devel@nongnu.org; Tue, 03 Sep 2013 04:42:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22374) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGmBR-00044J-Ge for qemu-devel@nongnu.org; Tue, 03 Sep 2013 04:41:57 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r838fuZ4032153 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 3 Sep 2013 04:41:56 -0400 Date: Tue, 3 Sep 2013 10:42:00 +0200 From: Kevin Wolf Message-ID: <20130903084200.GD2683@dhcp-200-207.str.redhat.com> References: <1378195795-1674-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1378195795-1674-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 0/6] block/qcow2: Image file option amendment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Am 03.09.2013 um 10:09 hat Max Reitz geschrieben: > > This series adds support to qemu-img, block and qcow2 for amending image > options on existing image files. > > Depends on: > - option: Add assigned flag to QEMUOptionParameter > - qcow2-refcount: Snapshot update for zero clusters (series, v3) > - Add metadata overlap checks (series, v5) > > v5: > - added a new function for emptying a cache (patch 2) > - fixed rounding for the bitmap size in qcow2_expand_zero_clusters > - now empties the cache in qcow2_expand_zero_clusters instead of simply > flushing it > - factored out assignment check in qcow2_amend_options > - fixed resizing by moving it to the end of qcow2_amend_options > - fixed expected test result for resizing in addition to a version > upgrade There's still room for improvements on top, in particular the additional test cases I suggested in the v4 thread and the real qcow2_truncate() fix that is just worked around here by moving its call (it needs to update bs->total_sectors), but this looks good enough to be merged now. Reviewed-by: Kevin Wolf