From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGmyY-0004B5-6M for qemu-devel@nongnu.org; Tue, 03 Sep 2013 05:32:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGmyU-0002Gj-5Y for qemu-devel@nongnu.org; Tue, 03 Sep 2013 05:32:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGmyT-0002Gb-SR for qemu-devel@nongnu.org; Tue, 03 Sep 2013 05:32:38 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r839WbXp026762 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 3 Sep 2013 05:32:37 -0400 Date: Tue, 3 Sep 2013 10:32:31 +0100 From: "Daniel P. Berrange" Message-ID: <20130903093231.GD32024@redhat.com> References: <1378114724-1748-1-git-send-email-gren@redhat.com> <1378114724-1748-4-git-send-email-gren@redhat.com> <20130902125757.GH15704@redhat.com> <1378194712.3618.12.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1378194712.3618.12.camel@nilsson.home.kraxel.org> Subject: Re: [Qemu-devel] [libvirt] [PATCH 3/5] qemu: add usb-bot support from disks points of view Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: libvir-list@redhat.com, Guannan Ren , qemu-devel@nongnu.org On Tue, Sep 03, 2013 at 09:51:52AM +0200, Gerd Hoffmann wrote: > On Mo, 2013-09-02 at 13:57 +0100, Daniel P. Berrange wrote: > > On Mon, Sep 02, 2013 at 05:38:42PM +0800, Guannan Ren wrote: > > > usb-bot only supports 16 luns(0~15) and they must be contiguous, > > > (using lun 0 and 2 without 1 doesn't work). In this case qemu > > > doesn't throw an error, we can not find the lun 2 in guests. So > > > Adding a checking function in libvirt to prevent from this case. > > > > Hmm, this seems like a problematic restriction. > > It's how the hardware works. > > > How does this work if we start off a guest with 3 disks > > attached to the usb-bot SCSI controller. Then hot-unplug > > the 2nd disk. > > You can't hotplug individual luns anyway. How does hotplug/unplug work in the context of usb-bot ? AFAIK we need to be able to run device_add usb_bot drive_add file... device_add scsi-hd And the reverse, to unplug it, if we're to have feature parity with usb-storage. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|