From: Stefan Hajnoczi <stefanha@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
david.brenner3@gmail.com, qemu-devel <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] w32: Fix access to host devices (regression)
Date: Tue, 3 Sep 2013 11:48:38 +0200 [thread overview]
Message-ID: <20130903094838.GD21758@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1378069165-10581-1-git-send-email-sw@weilnetz.de>
On Sun, Sep 01, 2013 at 10:59:25PM +0200, Stefan Weil wrote:
> QEMU failed to open host devices like \\.\PhysicalDrive0 (first hard disk)
> since some time (commit 8a79380b8ef1b02d2abd705dd026a18863b09020?).
>
> Those devices use hdev_open which did not use the latest API for options.
> This resulted in a fatal runtime error:
>
> Block protocol 'host_device' doesn't support the option 'filename'
>
> Duplicate code from raw_open to fix this.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> This bug was reported by David Brenner.
> It should be fixed in QEMU 1.6 as well.
>
> Stefan
>
> block/raw-win32.c | 36 +++++++++++++++++++++++++++++-------
> 1 file changed, 29 insertions(+), 7 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
prev parent reply other threads:[~2013-09-03 9:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 20:59 [Qemu-devel] [PATCH] w32: Fix access to host devices (regression) Stefan Weil
2013-09-03 8:51 ` Kevin Wolf
2013-09-03 9:55 ` Andreas Färber
2013-09-03 9:48 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903094838.GD21758@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=agraf@suse.de \
--cc=david.brenner3@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).