From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGnE8-0002EV-V5 for qemu-devel@nongnu.org; Tue, 03 Sep 2013 05:48:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGnE2-0007Ws-H6 for qemu-devel@nongnu.org; Tue, 03 Sep 2013 05:48:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGnE2-0007Wb-9D for qemu-devel@nongnu.org; Tue, 03 Sep 2013 05:48:42 -0400 Date: Tue, 3 Sep 2013 11:48:38 +0200 From: Stefan Hajnoczi Message-ID: <20130903094838.GD21758@stefanha-thinkpad.redhat.com> References: <1378069165-10581-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1378069165-10581-1-git-send-email-sw@weilnetz.de> Subject: Re: [Qemu-devel] [PATCH] w32: Fix access to host devices (regression) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Kevin Wolf , david.brenner3@gmail.com, qemu-devel , Alexander Graf On Sun, Sep 01, 2013 at 10:59:25PM +0200, Stefan Weil wrote: > QEMU failed to open host devices like \\.\PhysicalDrive0 (first hard disk) > since some time (commit 8a79380b8ef1b02d2abd705dd026a18863b09020?). > > Those devices use hdev_open which did not use the latest API for options. > This resulted in a fatal runtime error: > > Block protocol 'host_device' doesn't support the option 'filename' > > Duplicate code from raw_open to fix this. > > Signed-off-by: Stefan Weil > --- > > This bug was reported by David Brenner. > It should be fixed in QEMU 1.6 as well. > > Stefan > > block/raw-win32.c | 36 +++++++++++++++++++++++++++++------- > 1 file changed, 29 insertions(+), 7 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan