* [Qemu-devel] [PATCHv2] aio / timers: use g_usleep() not sleep()
@ 2013-08-29 22:32 Alex Bligh
2013-08-30 4:01 ` Stefan Weil
2013-09-03 9:58 ` [Qemu-devel] " Stefan Hajnoczi
0 siblings, 2 replies; 4+ messages in thread
From: Alex Bligh @ 2013-08-29 22:32 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Anthony Liguori, Alex Bligh, Jan Kiszka, liu ping fan,
Charlie Shepherd, Gerd Hoffmann, Stefan Hajnoczi, Stefan Weil,
Paolo Bonzini, MORITA Kazutaka, rth
sleep() apparently doesn't exist under mingw. Use g_usleep for
portability.
Signed-off-by: Alex Bligh <alex@alex.org.uk>
---
tests/test-aio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/test-aio.c b/tests/test-aio.c
index 4215701..c4fe0fc 100644
--- a/tests/test-aio.c
+++ b/tests/test-aio.c
@@ -400,7 +400,7 @@ static void test_timer_schedule(void)
g_assert(!aio_poll(ctx, false));
g_assert_cmpint(data.n, ==, 0);
- sleep(1);
+ g_usleep(1 * G_USEC_PER_SEC);
g_assert_cmpint(data.n, ==, 0);
g_assert(aio_poll(ctx, false));
@@ -736,7 +736,7 @@ static void test_source_timer_schedule(void)
g_assert_cmpint(data.n, ==, 0);
- sleep(1);
+ g_usleep(1 * G_USEC_PER_SEC);
g_assert_cmpint(data.n, ==, 0);
g_assert(g_main_context_iteration(NULL, false));
@@ -746,7 +746,7 @@ static void test_source_timer_schedule(void)
do {
g_assert(g_main_context_iteration(NULL, true));
} while (qemu_clock_get_ns(data.clock_type) <= expiry);
- sleep(1);
+ g_usleep(1 * G_USEC_PER_SEC);
g_main_context_iteration(NULL, false);
g_assert_cmpint(data.n, ==, 2);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCHv2] aio / timers: use g_usleep() not sleep()
2013-08-29 22:32 [Qemu-devel] [PATCHv2] aio / timers: use g_usleep() not sleep() Alex Bligh
@ 2013-08-30 4:01 ` Stefan Weil
2013-09-01 16:03 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-09-03 9:58 ` [Qemu-devel] " Stefan Hajnoczi
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Weil @ 2013-08-30 4:01 UTC (permalink / raw)
To: Alex Bligh; +Cc: qemu-trivial, qemu-devel
Am 30.08.2013 00:32, schrieb Alex Bligh:
> sleep() apparently doesn't exist under mingw. Use g_usleep for
> portability.
>
> Signed-off-by: Alex Bligh <alex@alex.org.uk>
> ---
> tests/test-aio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/test-aio.c b/tests/test-aio.c
> index 4215701..c4fe0fc 100644
> --- a/tests/test-aio.c
> +++ b/tests/test-aio.c
> @@ -400,7 +400,7 @@ static void test_timer_schedule(void)
> g_assert(!aio_poll(ctx, false));
> g_assert_cmpint(data.n, ==, 0);
>
> - sleep(1);
> + g_usleep(1 * G_USEC_PER_SEC);
> g_assert_cmpint(data.n, ==, 0);
>
> g_assert(aio_poll(ctx, false));
> @@ -736,7 +736,7 @@ static void test_source_timer_schedule(void)
>
> g_assert_cmpint(data.n, ==, 0);
>
> - sleep(1);
> + g_usleep(1 * G_USEC_PER_SEC);
> g_assert_cmpint(data.n, ==, 0);
>
> g_assert(g_main_context_iteration(NULL, false));
> @@ -746,7 +746,7 @@ static void test_source_timer_schedule(void)
> do {
> g_assert(g_main_context_iteration(NULL, true));
> } while (qemu_clock_get_ns(data.clock_type) <= expiry);
> - sleep(1);
> + g_usleep(1 * G_USEC_PER_SEC);
> g_main_context_iteration(NULL, false);
>
> g_assert_cmpint(data.n, ==, 2);
Reviewed-by: Stefan Weil <sw@weilnetz.de>
I cc'ed the mail to qemu-trivial, so it can be applied there.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCHv2] aio / timers: use g_usleep() not sleep()
2013-08-29 22:32 [Qemu-devel] [PATCHv2] aio / timers: use g_usleep() not sleep() Alex Bligh
2013-08-30 4:01 ` Stefan Weil
@ 2013-09-03 9:58 ` Stefan Hajnoczi
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2013-09-03 9:58 UTC (permalink / raw)
To: Alex Bligh
Cc: Kevin Wolf, Anthony Liguori, Jan Kiszka, qemu-devel, liu ping fan,
Charlie Shepherd, Gerd Hoffmann, Stefan Weil, Paolo Bonzini,
MORITA Kazutaka, rth
On Thu, Aug 29, 2013 at 11:32:14PM +0100, Alex Bligh wrote:
> sleep() apparently doesn't exist under mingw. Use g_usleep for
> portability.
>
> Signed-off-by: Alex Bligh <alex@alex.org.uk>
> ---
> tests/test-aio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-03 9:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-29 22:32 [Qemu-devel] [PATCHv2] aio / timers: use g_usleep() not sleep() Alex Bligh
2013-08-30 4:01 ` Stefan Weil
2013-09-01 16:03 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-09-03 9:58 ` [Qemu-devel] " Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).