From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VH8cd-0003Q6-SD for qemu-devel@nongnu.org; Wed, 04 Sep 2013 04:39:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VH8cZ-000859-E3 for qemu-devel@nongnu.org; Wed, 04 Sep 2013 04:39:31 -0400 Date: Wed, 4 Sep 2013 10:39:12 +0200 From: Stefan Hajnoczi Message-ID: <20130904083912.GC8031@stefanha-thinkpad.redhat.com> References: <1378120234-14062-1-git-send-email-aurelien@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1378120234-14062-1-git-send-email-aurelien@aurel32.net> Subject: Re: [Qemu-devel] [PATCH] ne2000: mark I/O as LITTLE_ENDIAN List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org On Mon, Sep 02, 2013 at 01:10:34PM +0200, Aurelien Jarno wrote: > Now that the memory subsystem is propagating the endianness correctly, > the ne2000 device should have its I/O ports marked as LITTLE_ENDIAN, as > PCI devices are little endian. > > This makes the ne2000 NIC to work again on PowerPC. > > Cc: qemu-stable@nongnu.org > Cc: Stefan Hajnoczi > Signed-off-by: Aurelien Jarno > --- > hw/net/ne2000.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c > index 31afd28..c961258 100644 > --- a/hw/net/ne2000.c > +++ b/hw/net/ne2000.c > @@ -693,7 +693,7 @@ static void ne2000_write(void *opaque, hwaddr addr, > static const MemoryRegionOps ne2000_ops = { > .read = ne2000_read, > .write = ne2000_write, > - .endianness = DEVICE_NATIVE_ENDIAN, > + .endianness = DEVICE_LITTLE_ENDIAN, > }; This is also used by hw/net/ne2000-isa.c:isa_ne2000_realizefn(). Is it correct to explicitly say little-endian there?