Re: [Qemu-devel] [PATCH] qemu-iotests: Fixed test case 026

[Stefan Hajnoczi <stefanha@gmail.com>]

On Mon, Sep 02, 2013 at 03:07:39PM +0200, Kevin Wolf wrote:
> Am 02.09.2013 um 14:58 hat Stefan Hajnoczi geschrieben:
> > On Mon, Sep 02, 2013 at 02:42:00PM +0200, Kevin Wolf wrote:
> > > diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
> > > index 74628ae..42d6955 100755
> > > --- a/tests/qemu-iotests/check
> > > +++ b/tests/qemu-iotests/check
> > > @@ -239,12 +239,18 @@ do
> > >  		echo -n " [failed, exit status $sts]"
> > >  		err=true
> > >  	    fi
> > > -	    if [ ! -f $seq.out ]
> > > +
> > > +        reference=$seq.out
> > 
> > Please keep the same indentation style as the rest of the file (seems to
> > use 8-space tabs plus spaces for 4-space indentation).
> 
> I could live with just tabs, but this kind of mix is a totally broken
> style. :-/
> 
> I'd rather send a patch to convert the whole qemu-iotests scripts to
> spaces first. Would you agree with that?

Yep.

Stefan