From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34789)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VH9oR-0000Zd-42
	for qemu-devel@nongnu.org; Wed, 04 Sep 2013 05:55:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VH9oI-0006e4-MG
	for qemu-devel@nongnu.org; Wed, 04 Sep 2013 05:55:47 -0400
Received: from mail-ee0-x234.google.com ([2a00:1450:4013:c00::234]:44587)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VH9oI-0006e0-BV
	for qemu-devel@nongnu.org; Wed, 04 Sep 2013 05:55:38 -0400
Received: by mail-ee0-f52.google.com with SMTP id c41so48646eek.11
	for <qemu-devel@nongnu.org>; Wed, 04 Sep 2013 02:55:37 -0700 (PDT)
Date: Wed, 4 Sep 2013 11:55:30 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130904095530.GC9654@stefanha-thinkpad.redhat.com>
References: <1378125720-6079-1-git-send-email-kwolf@redhat.com>
	<20130902125823.GA31868@stefanha-thinkpad.redhat.com>
	<20130902130739.GC3423@dhcp-200-207.str.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130902130739.GC3423@dhcp-200-207.str.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Fixed test case 026
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

On Mon, Sep 02, 2013 at 03:07:39PM +0200, Kevin Wolf wrote:
> Am 02.09.2013 um 14:58 hat Stefan Hajnoczi geschrieben:
> > On Mon, Sep 02, 2013 at 02:42:00PM +0200, Kevin Wolf wrote:
> > > diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
> > > index 74628ae..42d6955 100755
> > > --- a/tests/qemu-iotests/check
> > > +++ b/tests/qemu-iotests/check
> > > @@ -239,12 +239,18 @@ do
> > >  		echo -n " [failed, exit status $sts]"
> > >  		err=true
> > >  	    fi
> > > -	    if [ ! -f $seq.out ]
> > > +
> > > +        reference=$seq.out
> > 
> > Please keep the same indentation style as the rest of the file (seems to
> > use 8-space tabs plus spaces for 4-space indentation).
> 
> I could live with just tabs, but this kind of mix is a totally broken
> style. :-/
> 
> I'd rather send a patch to convert the whole qemu-iotests scripts to
> spaces first. Would you agree with that?

Yep.

Stefan