From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35864)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VH9tU-0002zG-HQ
	for qemu-devel@nongnu.org; Wed, 04 Sep 2013 06:01:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VH9tO-0008JI-MJ
	for qemu-devel@nongnu.org; Wed, 04 Sep 2013 06:01:00 -0400
Received: from mail-ea0-x22c.google.com ([2a00:1450:4013:c01::22c]:57667)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VH9tO-0008JC-EK
	for qemu-devel@nongnu.org; Wed, 04 Sep 2013 06:00:54 -0400
Received: by mail-ea0-f172.google.com with SMTP id r16so52742ead.3
	for <qemu-devel@nongnu.org>; Wed, 04 Sep 2013 03:00:53 -0700 (PDT)
Date: Wed, 4 Sep 2013 12:00:51 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130904100051.GD9654@stefanha-thinkpad.redhat.com>
References: <1378190626-21986-1-git-send-email-aik@ozlabs.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1378190626-21986-1-git-send-email-aik@ozlabs.ru>
Subject: Re: [Qemu-devel] [PATCH] kvm: fix traces to use %x instead of %d
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On Tue, Sep 03, 2013 at 04:43:46PM +1000, Alexey Kardashevskiy wrote:
> KVM request types are normally defined using hex constants but QEMU traces
> print decimal values instead what is not very convinient.
> 
> This changes the request type format from %d to %x.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  trace-events | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/trace-events b/trace-events
> index 4574f29..24cf4d2 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -1171,9 +1171,9 @@ virtio_ccw_new_device(int cssid, int ssid, int schid, int devno, const char *dev
>  migrate_set_state(int new_state) "new state %d"
>  
>  # kvm-all.c
> -kvm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d, arg %p"
> +kvm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %x, arg %p"
>  kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d"

It would be confusing for someone using these trace events today if you
silently change the base to hex.

To avoid confusion I would use 0x%x or %#x.  This way the output is
self-describing.

Stefan