[Qemu-devel] [PATCH v2] qmp: Documentation for BLOCK_IMAGE_CORRUPTED

[Qemu-devel] [PATCH v2] qmp: Documentation for BLOCK_IMAGE_CORRUPTED

[Max Reitz]

Add an appropriate entry describing this event and its parameters into
qmp-events.txt.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
v2:
 - moved section to keep qmp-events.txt sorted
---
 QMP/qmp-events.txt | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
index 39b6016..4b24ec9 100644
--- a/QMP/qmp-events.txt
+++ b/QMP/qmp-events.txt
@@ -18,6 +18,28 @@ Example:
     "data": { "actual": 944766976 },
     "timestamp": { "seconds": 1267020223, "microseconds": 435656 } }
 
+BLOCK_IMAGE_CORRUPTED
+---------------------
+
+Emitted when a disk image is being marked corrupt.
+
+Data:
+
+- "device": Device name (json-string)
+- "msg":    Informative message (e.g., reason for the corruption) (json-string)
+- "offset": If the corruption resulted from an image access, this is the access
+            offset into the image (json-int)
+- "size":   If the corruption resulted from an image access, this is the access
+            size (json-int)
+
+Example:
+
+{ "event": "BLOCK_IMAGE_CORRUPTED",
+    "data": { "device": "ide0-hd0",
+        "msg": "Prevented active L1 table overwrite", "offset": 196608,
+        "size": 65536 },
+    "timestamp": { "seconds": 1378126126, "microseconds": 966463 } }
+
 BLOCK_IO_ERROR
 --------------
 
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH v2] qmp: Documentation for BLOCK_IMAGE_CORRUPTED

[Kevin Wolf]

Am 03.09.2013 um 15:49 hat Max Reitz geschrieben:
> Add an appropriate entry describing this event and its parameters into
> qmp-events.txt.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> v2:
>  - moved section to keep qmp-events.txt sorted

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

Don't forget to keep both Stefan and me CCed for block layer patches.
This week Stefan handles the queue.

Kevin

>  QMP/qmp-events.txt | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
> index 39b6016..4b24ec9 100644
> --- a/QMP/qmp-events.txt
> +++ b/QMP/qmp-events.txt
> @@ -18,6 +18,28 @@ Example:
>      "data": { "actual": 944766976 },
>      "timestamp": { "seconds": 1267020223, "microseconds": 435656 } }
>  
> +BLOCK_IMAGE_CORRUPTED
> +---------------------
> +
> +Emitted when a disk image is being marked corrupt.
> +
> +Data:
> +
> +- "device": Device name (json-string)
> +- "msg":    Informative message (e.g., reason for the corruption) (json-string)
> +- "offset": If the corruption resulted from an image access, this is the access
> +            offset into the image (json-int)
> +- "size":   If the corruption resulted from an image access, this is the access
> +            size (json-int)
> +
> +Example:
> +
> +{ "event": "BLOCK_IMAGE_CORRUPTED",
> +    "data": { "device": "ide0-hd0",
> +        "msg": "Prevented active L1 table overwrite", "offset": 196608,
> +        "size": 65536 },
> +    "timestamp": { "seconds": 1378126126, "microseconds": 966463 } }
> +
>  BLOCK_IO_ERROR
>  --------------
>  
> -- 
> 1.8.3.1
> 
> 

Re: [Qemu-devel] [PATCH v2] qmp: Documentation for BLOCK_IMAGE_CORRUPTED

[Stefan Hajnoczi]

On Tue, Sep 03, 2013 at 03:49:39PM +0200, Max Reitz wrote:
> Add an appropriate entry describing this event and its parameters into
> qmp-events.txt.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> v2:
>  - moved section to keep qmp-events.txt sorted
> ---
>  QMP/qmp-events.txt | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan