From: Kevin Wolf <kwolf@redhat.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>
Cc: famz@redhat.com, jcody@redhat.com, armbru@redhat.com,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
pbonzini@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] Block Filters
Date: Thu, 5 Sep 2013 09:32:42 +0200 [thread overview]
Message-ID: <20130905073242.GB2826@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <20130904181535.GA5073@irqsave.net>
Am 04.09.2013 um 20:15 hat Benoît Canet geschrieben:
> > Propagate operations like snapshot down the tree. block.c is designed
> > for bs->file/bs->backing_hd kind of BlockDrivers, perhaps it needs to
> > become a bit more generic to support other types of BlockDrivers
> > properly.
>
> Shouldn't bs->backing_hd become bs->children[0] and bs->file stay the same ?
Intuitively I'd say that bs->children[] would contain _all_ children,
including bs->file and bs->backing_hd.
In the end it all depends on what bs->children[] would be used for.
I'm not even sure if the generic block layer has any use for this
information.
Kevin
next prev parent reply other threads:[~2013-09-05 7:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 16:24 [Qemu-devel] Block Filters Benoît Canet
2013-09-04 8:29 ` Stefan Hajnoczi
2013-09-04 18:15 ` Benoît Canet
2013-09-05 7:32 ` Kevin Wolf [this message]
2013-09-05 10:01 ` Stefan Hajnoczi
2013-09-05 10:18 ` Fam Zheng
2013-09-05 14:59 ` Stefan Hajnoczi
2013-09-05 17:29 ` Benoît Canet
2013-09-06 7:42 ` Kevin Wolf
2013-09-06 7:49 ` Fam Zheng
2013-09-06 7:56 ` Fam Zheng
2013-09-06 8:45 ` Kevin Wolf
2013-09-06 9:18 ` Fam Zheng
2013-09-06 9:55 ` Kevin Wolf
2013-09-06 10:50 ` Fam Zheng
2013-09-15 18:10 ` Benoît Canet
2013-09-16 7:41 ` Fam Zheng
2013-09-16 10:43 ` Benoît Canet
2013-09-16 11:00 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130905073242.GB2826@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).