From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHV9I-0001Hr-Uz for qemu-devel@nongnu.org; Thu, 05 Sep 2013 04:42:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHV9C-0006ID-N5 for qemu-devel@nongnu.org; Thu, 05 Sep 2013 04:42:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHV9C-0006Hi-FZ for qemu-devel@nongnu.org; Thu, 05 Sep 2013 04:42:38 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r858gbGQ012950 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 5 Sep 2013 04:42:37 -0400 Date: Thu, 5 Sep 2013 10:42:35 +0200 From: Kevin Wolf Message-ID: <20130905084235.GC2826@dhcp-200-207.str.redhat.com> References: <1378368620-22682-1-git-send-email-mreitz@redhat.com> <1378368620-22682-2-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1378368620-22682-2-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [RFC 1/3] bdrv: Use "Error" for opening images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Am 05.09.2013 um 10:10 hat Max Reitz geschrieben: > Add an Error ** parameter to bdrv_open, bdrv_file_open and bdrv_create > to allow more specific error messages. > > Signed-off-by: Max Reitz > --- > block.c | 6 +++--- > block/blkdebug.c | 3 ++- > block/blkverify.c | 3 ++- > block/bochs.c | 3 ++- > block/cloop.c | 3 ++- > block/cow.c | 6 ++++-- > block/dmg.c | 3 ++- > block/nbd.c | 3 ++- > block/parallels.c | 3 ++- > block/qcow.c | 6 ++++-- > block/qcow2.c | 8 +++++--- > block/qed.c | 8 +++++--- > block/raw-posix.c | 18 ++++++++++++------ > block/raw_bsd.c | 6 ++++-- > block/sheepdog.c | 6 ++++-- > block/snapshot.c | 2 +- > block/vdi.c | 6 ++++-- > block/vhdx.c | 3 ++- > block/vmdk.c | 6 ++++-- > block/vpc.c | 6 ++++-- > block/vvfat.c | 3 ++- > include/block/block_int.h | 9 ++++++--- > 22 files changed, 78 insertions(+), 42 deletions(-) Don't rely on compiler errors for changing the prototypes: There are more block drivers which just aren't compiled on your system, either because they are for a different platform (like raw-win32.c) or they require headers that you don't have installed, so configure disabled them. Kevin