From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHxJH-0005GW-JO for qemu-devel@nongnu.org; Fri, 06 Sep 2013 10:47:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHxJC-0003Ql-E3 for qemu-devel@nongnu.org; Fri, 06 Sep 2013 10:46:55 -0400 Received: from wanbli.kerneis.info ([2001:41d0:8:38ad::1]:58872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHxJC-0003Qc-24 for qemu-devel@nongnu.org; Fri, 06 Sep 2013 10:46:50 -0400 Date: Fri, 6 Sep 2013 15:46:47 +0100 From: Gabriel Kerneis Message-ID: <20130906144647.GC7398@kerneis.info> References: <1378477839-7353-1-git-send-email-gabriel@kerneis.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1378477839-7353-1-git-send-email-gabriel@kerneis.info> Subject: Re: [Qemu-devel] [RFC] Introducing CoroCheck and proposal for a blocking_fn annotation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@gmail.com, pbonzini@redhat.com, charlie@ctshepherd.com On Fri, Sep 06, 2013 at 03:30:38PM +0100, Gabriel Kerneis wrote: > More precisely, here is what CoroCheck does for each file of QEMU: > - produce a .dot file that can be processed with graphviz to produce a > pdf of the annotated call graph (with wrong annotations showing up in > red - this still needs to be documented properly). For those of you interested in finding out what those graphs look like, I have uploaded the result for qemu-coroutine-lock.c here: http://www.scribd.com/doc/166033638/qemu-coroutine-lock-c As explained on the right: - Square = should be coroutine_fn - Circle = need not be coroutine_fn - Dashed red = wrong annotation (either missing or spurious) Best regards, -- Gabriel