From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37909)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VHxxW-0004rt-8R
	for qemu-devel@nongnu.org; Fri, 06 Sep 2013 11:28:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VHxxN-0001pO-1x
	for qemu-devel@nongnu.org; Fri, 06 Sep 2013 11:28:30 -0400
Date: Fri, 6 Sep 2013 17:28:15 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130906152815.GA20542@stefanha-thinkpad.redhat.com>
References: <1378120234-14062-1-git-send-email-aurelien@aurel32.net>
	<20130904083912.GC8031@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130904083912.GC8031@stefanha-thinkpad.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] ne2000: mark I/O as LITTLE_ENDIAN
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>, qemu-stable@nongnu.org

On Wed, Sep 04, 2013 at 10:39:12AM +0200, Stefan Hajnoczi wrote:
> On Mon, Sep 02, 2013 at 01:10:34PM +0200, Aurelien Jarno wrote:
> > Now that the memory subsystem is propagating the endianness correctly,
> > the ne2000 device should have its I/O ports marked as LITTLE_ENDIAN, as
> > PCI devices are little endian.
> > 
> > This makes the ne2000 NIC to work again on PowerPC.
> > 
> > Cc: qemu-stable@nongnu.org
> > Cc: Stefan Hajnoczi <stefanha@redhat.com>
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > ---
> >  hw/net/ne2000.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c
> > index 31afd28..c961258 100644
> > --- a/hw/net/ne2000.c
> > +++ b/hw/net/ne2000.c
> > @@ -693,7 +693,7 @@ static void ne2000_write(void *opaque, hwaddr addr,
> >  static const MemoryRegionOps ne2000_ops = {
> >      .read = ne2000_read,
> >      .write = ne2000_write,
> > -    .endianness = DEVICE_NATIVE_ENDIAN,
> > +    .endianness = DEVICE_LITTLE_ENDIAN,
> >  };
> 
> This is also used by hw/net/ne2000-isa.c:isa_ne2000_realizefn().  Is it
> correct to explicitly say little-endian there?

Paolo has confirmed that ISA devices should be little-endian anyway.

Thanks, applied to my net tree.

Stefan