From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHyXJ-0000hU-He for qemu-devel@nongnu.org; Fri, 06 Sep 2013 12:05:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHyXD-0006Ep-WB for qemu-devel@nongnu.org; Fri, 06 Sep 2013 12:05:29 -0400 Received: from wanbli.kerneis.info ([2001:41d0:8:38ad::1]:59049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHyXD-0006EN-L0 for qemu-devel@nongnu.org; Fri, 06 Sep 2013 12:05:23 -0400 Date: Fri, 6 Sep 2013 17:05:20 +0100 From: Gabriel Kerneis Message-ID: <20130906160519.GA7913@kerneis.info> References: <1378477839-7353-1-git-send-email-gabriel@kerneis.info> <5229F68F.8060704@ctshepherd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5229F68F.8060704@ctshepherd.com> Subject: Re: [Qemu-devel] [RFC] Introducing CoroCheck and proposal for a blocking_fn annotation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Charlie Shepherd Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, pbonzini@redhat.com On Fri, Sep 06, 2013 at 04:36:47PM +0100, Charlie Shepherd wrote: > However, I'm not sure it makes sense to use blocking_fn until the > convert-block series (which currently needs a respin after Stefan's > review) is fully upstreamed. Maybe this patch makes most sense at > the start of that series? Yes, definitely, that's why I labeled it RFC rather than PATCH. But if people agree, it would make much more sense to have the annotations within your patch series rather than added later (notwithstanding the fact that it would ease your refactoring effort). Best, -- Gabriel