From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VIzoZ-0004Dr-TF for qemu-devel@nongnu.org; Mon, 09 Sep 2013 07:39:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VIzoP-0003hw-4t for qemu-devel@nongnu.org; Mon, 09 Sep 2013 07:39:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15310) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VIzoO-0003hk-Sz for qemu-devel@nongnu.org; Mon, 09 Sep 2013 07:39:21 -0400 Date: Mon, 9 Sep 2013 14:41:23 +0300 From: "Michael S. Tsirkin" Message-ID: <20130909114123.GC31476@redhat.com> References: <1378725696-13590-1-git-send-email-marcel.a@redhat.com> <1378725696-13590-2-git-send-email-marcel.a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1378725696-13590-2-git-send-email-marcel.a@redhat.com> Subject: Re: [Qemu-devel] [PATCH RFC v3 1/2] memory: allow MemoryRegion's priority field to accept negative values List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: pbonzini@redhat.com, aliguori@us.ibm.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, peter.maydell@linaro.org On Mon, Sep 09, 2013 at 02:21:35PM +0300, Marcel Apfelbaum wrote: > Priority is used to make visible some subregions by obscuring > the parent MemoryRegion addresses overlapping with the subregion. > > By allowing the priority to be negative the opposite can be done: > Allow a subregion to be visible on all the addresses not covered > by the parent MemoryRegion or other subregions. > > Signed-off-by: Marcel Apfelbaum Seems harmless enough. Reviewed-by: Michael S. Tsirkin > --- > include/exec/memory.h | 6 +++--- > memory.c | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index ebe0d24..6995087 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -153,7 +153,7 @@ struct MemoryRegion { > bool flush_coalesced_mmio; > MemoryRegion *alias; > hwaddr alias_offset; > - unsigned priority; > + int priority; > bool may_overlap; > QTAILQ_HEAD(subregions, MemoryRegion) subregions; > QTAILQ_ENTRY(MemoryRegion) subregions_link; > @@ -193,7 +193,7 @@ struct MemoryListener { > void (*coalesced_mmio_del)(MemoryListener *listener, MemoryRegionSection *section, > hwaddr addr, hwaddr len); > /* Lower = earlier (during add), later (during del) */ > - unsigned priority; > + int priority; > AddressSpace *address_space_filter; > QTAILQ_ENTRY(MemoryListener) link; > }; > @@ -779,7 +779,7 @@ void memory_region_add_subregion(MemoryRegion *mr, > void memory_region_add_subregion_overlap(MemoryRegion *mr, > hwaddr offset, > MemoryRegion *subregion, > - unsigned priority); > + int priority); > > /** > * memory_region_get_ram_addr: Get the ram address associated with a memory > diff --git a/memory.c b/memory.c > index 5a10fd0..984a3dc 100644 > --- a/memory.c > +++ b/memory.c > @@ -1473,7 +1473,7 @@ void memory_region_add_subregion(MemoryRegion *mr, > void memory_region_add_subregion_overlap(MemoryRegion *mr, > hwaddr offset, > MemoryRegion *subregion, > - unsigned priority) > + int priority) > { > subregion->may_overlap = true; > subregion->priority = priority; > -- > 1.8.3.1