From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35386)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VIzvn-0007Xz-Lg
	for qemu-devel@nongnu.org; Mon, 09 Sep 2013 07:47:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VIzvg-0005YU-5D
	for qemu-devel@nongnu.org; Mon, 09 Sep 2013 07:46:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20868)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VIzvf-0005YG-TX
	for qemu-devel@nongnu.org; Mon, 09 Sep 2013 07:46:52 -0400
Date: Mon, 9 Sep 2013 14:48:55 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130909114855.GF31476@redhat.com>
References: <1378725696-13590-1-git-send-email-marcel.a@redhat.com>
	<1378725696-13590-2-git-send-email-marcel.a@redhat.com>
	<20130909114123.GC31476@redhat.com>
	<CAFEAcA-=SjR4mnU-U_-3duwyYocBjTg=CeiWsCE=Eq=sDCEdmA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA-=SjR4mnU-U_-3duwyYocBjTg=CeiWsCE=Eq=sDCEdmA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH RFC v3 1/2] memory: allow MemoryRegion's
 priority field to accept negative values
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Jan Kiszka <jan.kiszka@siemens.com>, QEMU Developers <qemu-devel@nongnu.org>, Marcel Apfelbaum <marcel.a@redhat.com>

On Mon, Sep 09, 2013 at 12:45:12PM +0100, Peter Maydell wrote:
> On 9 September 2013 12:41, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Mon, Sep 09, 2013 at 02:21:35PM +0300, Marcel Apfelbaum wrote:
> >> Priority is used to make visible some subregions by obscuring
> >> the parent MemoryRegion addresses overlapping with the subregion.
> >>
> >> By allowing the priority to be negative the opposite can be done:
> >> Allow a subregion to be visible on all the addresses not covered
> >> by the parent MemoryRegion or other subregions.
> >>
> >> Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> >
> > Seems harmless enough.
> >
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> 
> No, the idea is good but this version is just broken.
> See the comments I made on the previous version which
> Marcel ignored :-(
> 
> -- PMM

You are right, I missed the bugs.
Good catch, thanks.