From: Stefan Hajnoczi <stefanha@gmail.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] kvm: fix traces to use %x instead of %d
Date: Mon, 9 Sep 2013 14:07:50 +0200 [thread overview]
Message-ID: <20130909120750.GA20923@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1378290385-7003-1-git-send-email-aik@ozlabs.ru>
On Wed, Sep 04, 2013 at 08:26:25PM +1000, Alexey Kardashevskiy wrote:
> KVM request types are normally defined using hex constants but QEMU traces
> print decimal values instead, which is not very convenient.
>
> This changes the request type format from %d to %x.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Reviewed-by: Andreas Färber <afaerber@suse.de>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> Changes:
> v2:
> * added "0x" to format strings so the change won't come unnoticed
> * fixed the commit message
> ---
> trace-events | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
next prev parent reply other threads:[~2013-09-09 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 10:26 [Qemu-devel] [PATCH v2] kvm: fix traces to use %x instead of %d Alexey Kardashevskiy
2013-09-09 12:07 ` Stefan Hajnoczi [this message]
2013-09-12 16:31 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909120750.GA20923@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=aik@ozlabs.ru \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).