From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJP4f-0007qG-Td for qemu-devel@nongnu.org; Tue, 10 Sep 2013 10:37:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJP4Y-0002b2-V6 for qemu-devel@nongnu.org; Tue, 10 Sep 2013 10:37:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12028) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJP4Y-0002ap-Nl for qemu-devel@nongnu.org; Tue, 10 Sep 2013 10:37:42 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8AEbfUe029305 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 10 Sep 2013 10:37:42 -0400 Date: Tue, 10 Sep 2013 16:37:44 +0200 From: Kevin Wolf Message-ID: <20130910143744.GF2797@dhcp-200-207.str.redhat.com> References: <1378482755-31669-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1378482755-31669-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [RFC v3 0/6] block: Error parameter for opening/creating images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Am 06.09.2013 um 17:52 hat Max Reitz geschrieben: > This RFC adds an Error ** parameter to bdrv_open, bdrv_file_open, > bdrv_create and the respective functions provided by a block driver. > > This results in more specific error information than just -errno provided > to the user when opening or creating images (disregarding the fact that > block drivers often already use error_report, which is generally changed > to error_setg through this patch). > > The sixth patch in this series changes the qcow2 block driver to set an > example of usage in a block driver. > > Note that several I/O tests break by applying this RFC since they expect > different error messages (generally, previously, an error message on > image opening/creation consisted of two lines; the first of which would be > generated by the driver through error_report, the second by the block > layer itself through strerror(-ret); this patch is designed to merge these > two lines into a single one). This applies to the tests 49, 51, 54 and 60. Looks good to me now (except that it needs a rebase because it conflicts with other recent patches in the block tree). I guess it's time to address the qemu-iotests part and send out a non-RFC series. Kevin