From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJfcS-0003u0-H7 for qemu-devel@nongnu.org; Wed, 11 Sep 2013 04:17:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJfcM-0002LL-EX for qemu-devel@nongnu.org; Wed, 11 Sep 2013 04:17:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50230) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJfcM-0002L1-5o for qemu-devel@nongnu.org; Wed, 11 Sep 2013 04:17:42 -0400 Date: Wed, 11 Sep 2013 16:17:34 +0800 From: Fam Zheng Message-ID: <20130911081734.GA28040@T430s.nay.redhat.com> References: <1378877909-28518-1-git-send-email-famz@redhat.com> <1378877909-28518-6-git-send-email-famz@redhat.com> <52301B4E.7000308@redhat.com> <52301EBD.5070209@redhat.com> <1378886460.15290.4.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1378886460.15290.4.camel@nilsson.home.kraxel.org> Subject: Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules Reply-To: famz@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: peter.maydell@linaro.org, mjt@tls.msk.ru, qemu-devel@nongnu.org, stefanha@redhat.com, Paolo Bonzini , vilanova@ac.upc.edu, rth@twiddle.net On Wed, 09/11 10:01, Gerd Hoffmann wrote: > On Mi, 2013-09-11 at 09:41 +0200, Paolo Bonzini wrote: > > Il 11/09/2013 09:27, Paolo Bonzini ha scritto: > > > > > > There are a couple of things that can be improved still (I don't like > > > obj-save-y for example), but things are taking shape and all of this > > > looks like something that can be fixed on top. If you look at > > > converting more parts to modules (e.g. rbd or spice), you can drop that > > > RFC! :) > > > > Talking about spice, a question for Gerd. > > > > With Fam's work to enable shared modules, hw/display/qxl* would have to > > be placed in a module as well because they depend on ui/spice-core.c. > > Yes. Can modules depend on modules? Or would we have to create a > single, big spice module with core, qxl, audio, chardev etc? > No dependence support yet. Fam > > Right now, modularization is limited to files that are built once for > > all of QEMU, which is not the case for qxl. > > > > It looks like TARGET_PAGE_SIZE is the only reason why qxl is built > > per-target, and in qxl_ram_set_dirty it should be enough to do > > > > qxl_set_dirty(&qxl->vga.vram, offset, offset + 1); > > > > Would it be fine to use a generic 4096 constant everywhere else? > > Yes. Maybe s/TARGET_PAGE_SIZE/QXL_PAGE_SIZE/ to make clear that qxl > operates on 4k pages. > > cheers, > Gerd > >