From: Kevin Wolf <kwolf@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: phrdina@redhat.com, famz@redhat.com, armbru@redhat.com,
qemu-devel@nongnu.org, lcapitulino@redhat.com,
stefanha@redhat.com, pbonzini@redhat.com, dietmar@proxmox.com
Subject: Re: [Qemu-devel] [PATCH V8 0/8] add internal snapshot support at block device level
Date: Wed, 11 Sep 2013 10:41:49 +0200 [thread overview]
Message-ID: <20130911084149.GC2305@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1378879479-10068-1-git-send-email-xiawenc@linux.vnet.ibm.com>
Am 11.09.2013 um 08:04 hat Wenchao Xia geschrieben:
> This series brings internal snapshot support at block devices level, now we
> have two three methods to do block snapshot lively: 1) backing chain,
> 2) internal one and 3) drive-back up approach.
>
> Comparation:
> Advantages: Disadvantages:
> 1) delta data, taken fast, export, size performance, delete slow.
> 2) taken fast, delete fast, performance, size delta data, format
> 3) performance, export, format taken slow, delta data, size, host I/O
>
> I think in most case, saving vmstate in an standalone file is better than
> saving it inside qcow2, So suggest treat internal snapshot as block level
> methods and not encourage user to savevm in qcow2 any more.
>
> Implemention details:
> To avoid trouble, this serial have hide ID in create interfaces, this make
> sure no chaos of ID and name will be introduced by these interfaces.
> There is one patch may be common to Pavel's savvm transaction, patch 1/11,
> others are not quite related. Patch 1/11 will not set errp when no snapshot
> find, since patch 3/11 need to distinguish real error case.
>
> Next steps to better full VM snapshot:
> Improve internal snapshot's export capability.
> Better vmstate saving.
>
> Thanks Kevin to give advisement about how add it in qmp_transaction, oldest
> version comes from Dietmar Maurer.
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2013-09-11 8:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 6:04 [Qemu-devel] [PATCH V8 0/8] add internal snapshot support at block device level Wenchao Xia
2013-09-11 6:04 ` [Qemu-devel] [PATCH V8 1/8] snapshot: new function bdrv_snapshot_find_by_id_and_name() Wenchao Xia
2013-09-11 6:04 ` [Qemu-devel] [PATCH V8 2/8] snapshot: distinguish id and name in snapshot delete Wenchao Xia
2013-09-11 6:04 ` [Qemu-devel] [PATCH V8 3/8] qmp: add internal snapshot support in qmp_transaction Wenchao Xia
2013-09-11 6:04 ` [Qemu-devel] [PATCH V8 4/8] qmp: add interface blockdev-snapshot-internal-sync Wenchao Xia
2013-09-11 6:04 ` [Qemu-devel] [PATCH V8 5/8] qmp: add interface blockdev-snapshot-delete-internal-sync Wenchao Xia
2013-09-11 6:04 ` [Qemu-devel] [PATCH V8 6/8] hmp: add interface hmp_snapshot_blkdev_internal Wenchao Xia
2013-09-11 6:04 ` [Qemu-devel] [PATCH V8 7/8] hmp: add interface hmp_snapshot_delete_blkdev_internal Wenchao Xia
2013-09-11 6:04 ` [Qemu-devel] [PATCH V8 8/8] qemu-iotests: add 057 internal snapshot for block device test case Wenchao Xia
2013-09-11 8:41 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130911084149.GC2305@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=dietmar@proxmox.com \
--cc=famz@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=phrdina@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).