From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJm81-00071r-0D for qemu-devel@nongnu.org; Wed, 11 Sep 2013 11:14:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJm7v-0000Oy-6C for qemu-devel@nongnu.org; Wed, 11 Sep 2013 11:14:48 -0400 Date: Wed, 11 Sep 2013 16:14:28 +0100 From: Gabriel Kerneis Message-ID: <20130911151428.GA22569@kerneis.info> References: <1378906912-14015-1-git-send-email-gabriel@kerneis.info> <523077CE.6070303@redhat.com> <20130911144230.GA15227@kerneis.info> <523083EF.7050203@redhat.com> <20130911150137.GC15227@kerneis.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130911150137.GC15227@kerneis.info> Subject: Re: [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-trivial@nongnu.org, Peter Maydell , qemu-devel@nongnu.org On Wed, Sep 11, 2013 at 04:01:37PM +0100, Gabriel Kerneis wrote: > On Wed, Sep 11, 2013 at 04:53:35PM +0200, Paolo Bonzini wrote: > > Oh, then it's this line in configure that has to be changed to do proper > > quoting. > > > > printf "# Configured with:" >> $config_host_mak > > printf " '%s'" "$0" "$@" >> $config_host_mak > > No, this line has absolutely nothing to do with it. I'm sorry, you are correct. I was confused because I did not try your proposal from a clean build directory, running into a chicken-and-egg issue. I'll propose an updated patch. -- Gabriel