From: Gabriel Kerneis <gabriel@kerneis.info>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] coroutine: add ./configure --disable-coroutine-pool
Date: Wed, 11 Sep 2013 16:32:22 +0100 [thread overview]
Message-ID: <20130911153222.GD22569@kerneis.info> (raw)
In-Reply-To: <20130911152455.GL2305@dhcp-200-207.str.redhat.com>
On Wed, Sep 11, 2013 at 05:24:55PM +0200, Kevin Wolf wrote:
> In config-host.make we do get:
>
> CONFIG_COROUTINE_POOL=0
>
> But when config-host.h is generated from it, I assume it's only checked
> if the variable is defined, so we end up with:
>
> #define CONFIG_COROUTINE_POOL 1
Did you clean your tree?
$ rm -rf *
$ ../../configure --disable-coroutine-pool
$ make config-host.h
$ grep COROUTINE_POOL config-host.h
#define CONFIG_COROUTINE_POOL 0
And scripts/create_config seems to take the value into account:
CONFIG_*=*) # configuration
name=${line%=*}
value=${line#*=}
echo "#define $name $value"
;;
--
Gabriel
next prev parent reply other threads:[~2013-09-11 15:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 14:42 [Qemu-devel] [PATCH] coroutine: add ./configure --disable-coroutine-pool Stefan Hajnoczi
2013-09-11 14:56 ` Gabriel Kerneis
2013-09-11 15:24 ` Kevin Wolf
2013-09-11 15:32 ` Gabriel Kerneis [this message]
2013-09-11 15:38 ` Kevin Wolf
2013-09-12 8:42 ` Stefan Hajnoczi
2013-09-27 5:20 ` Stefan Weil
2013-09-27 9:11 ` Stefan Hajnoczi
2013-09-27 16:49 ` Stefan Weil
2013-09-30 9:06 ` Stefan Hajnoczi
2013-10-01 5:51 ` Stefan Weil
2013-10-01 7:29 ` Gabriel Kerneis
2013-10-01 16:44 ` Stefan Weil
2013-10-02 8:54 ` Stefan Hajnoczi
2013-10-02 21:15 ` Stefan Weil
2013-10-04 7:30 ` Stefan Hajnoczi
2013-10-01 7:21 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130911153222.GD22569@kerneis.info \
--to=gabriel@kerneis.info \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).