From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51531)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gabriel@kerneis.info>) id 1VJmP8-0006kk-8x
	for qemu-devel@nongnu.org; Wed, 11 Sep 2013 11:32:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gabriel@kerneis.info>) id 1VJmP2-0006sc-Hl
	for qemu-devel@nongnu.org; Wed, 11 Sep 2013 11:32:30 -0400
Received: from wanbli.kerneis.info ([2001:41d0:8:38ad::1]:42266)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gabriel@kerneis.info>) id 1VJmP2-0006rN-9Y
	for qemu-devel@nongnu.org; Wed, 11 Sep 2013 11:32:24 -0400
Date: Wed, 11 Sep 2013 16:32:22 +0100
From: Gabriel Kerneis <gabriel@kerneis.info>
Message-ID: <20130911153222.GD22569@kerneis.info>
References: <1378910555-24753-1-git-send-email-stefanha@redhat.com>
	<20130911152455.GL2305@dhcp-200-207.str.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130911152455.GL2305@dhcp-200-207.str.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] coroutine: add ./configure
	--disable-coroutine-pool
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Wed, Sep 11, 2013 at 05:24:55PM +0200, Kevin Wolf wrote:
> In config-host.make we do get:
> 
>     CONFIG_COROUTINE_POOL=0
> 
> But when config-host.h is generated from it, I assume it's only checked
> if the variable is defined, so we end up with:
> 
>     #define CONFIG_COROUTINE_POOL 1

Did you clean your tree?

$ rm -rf *
$ ../../configure --disable-coroutine-pool
$ make config-host.h
$ grep COROUTINE_POOL config-host.h
#define CONFIG_COROUTINE_POOL 0

And scripts/create_config seems to take the value into account:

 CONFIG_*=*) # configuration
    name=${line%=*}
    value=${line#*=}
    echo "#define $name $value"
    ;;

-- 
Gabriel