From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52735)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VJmUj-0008SR-Kf
	for qemu-devel@nongnu.org; Wed, 11 Sep 2013 11:38:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VJmUa-0000Nu-9L
	for qemu-devel@nongnu.org; Wed, 11 Sep 2013 11:38:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40207)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VJmUa-0000Ne-11
	for qemu-devel@nongnu.org; Wed, 11 Sep 2013 11:38:08 -0400
Date: Wed, 11 Sep 2013 17:38:07 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130911153807.GM2305@dhcp-200-207.str.redhat.com>
References: <1378910555-24753-1-git-send-email-stefanha@redhat.com>
	<20130911152455.GL2305@dhcp-200-207.str.redhat.com>
	<20130911153222.GD22569@kerneis.info>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130911153222.GD22569@kerneis.info>
Subject: Re: [Qemu-devel] [PATCH] coroutine: add ./configure
	--disable-coroutine-pool
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gabriel Kerneis <gabriel@kerneis.info>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 11.09.2013 um 17:32 hat Gabriel Kerneis geschrieben:
> On Wed, Sep 11, 2013 at 05:24:55PM +0200, Kevin Wolf wrote:
> > In config-host.make we do get:
> > 
> >     CONFIG_COROUTINE_POOL=0
> > 
> > But when config-host.h is generated from it, I assume it's only checked
> > if the variable is defined, so we end up with:
> > 
> >     #define CONFIG_COROUTINE_POOL 1
> 
> Did you clean your tree?
> 
> $ rm -rf *
> $ ../../configure --disable-coroutine-pool
> $ make config-host.h
> $ grep COROUTINE_POOL config-host.h
> #define CONFIG_COROUTINE_POOL 0

My bad, I checked after configure, but before running make. We must have
a weird build system that this isn't created during configure. :-)

Thanks, applied to the block branch.

Kevin