qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: peter.maydell@linaro.org, mjt@tls.msk.ru, qemu-devel@nongnu.org,
	stefanha@redhat.com, pbonzini@redhat.com, vilanova@ac.upc.edu,
	rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v6 8/8] block: convert block drivers linked with libs to modules
Date: Wed, 11 Sep 2013 16:41:38 +0100	[thread overview]
Message-ID: <20130911154138.GC2293@redhat.com> (raw)
In-Reply-To: <1378906448-15834-9-git-send-email-famz@redhat.com>

On Wed, Sep 11, 2013 at 09:34:08PM +0800, Fam Zheng wrote:
> The converted block drivers are:
> 
>     curl
>     iscsi
>     rbd
>     ssh
>     glusterfs
> 
> no longer adds flags and libs for them to global variables, instead
> create config-host.mak variables like FOO_CFLAGS and FOO_LIBS, which is
> used as per object cflags and libs.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  block/Makefile.objs | 11 ++++++++++-
>  configure           | 33 +++++++++++++++------------------
>  2 files changed, 25 insertions(+), 19 deletions(-)

After this is applied, I can no longer use http:/// URIs with the
curl driver, if I do not build with  '--enable-modules' passed to
configure.

  $  ~/usr/qemu-git/bin/qemu-system-x86_64 -cdrom http://www.mirrorservice.org/sites/dl.fedoraproject.org/pub/fedora/linux//releases/19/Fedora/x86_64/os/images/boot.iso
qemu-system-x86_64: -cdrom http://www.mirrorservice.org/sites/dl.fedoraproject.org/pub/fedora/linux//releases/19/Fedora/x86_64/os/images/boot.iso: Unknown protocol
qemu-system-x86_64: -cdrom http://www.mirrorservice.org/sites/dl.fedoraproject.org/pub/fedora/linux//releases/19/Fedora/x86_64/os/images/boot.iso: could not open disk image http://www.mirrorservice.org/sites/dl.fedoraproject.org/pub/fedora/linux//releases/19/Fedora/x86_64/os/images/boot.iso: No such file or directory


So it seems driver registration is broken in some way when modules aren't
enabled at compile time.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

  reply	other threads:[~2013-09-11 15:41 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-11 13:34 [Qemu-devel] [PATCH v6 0/8] Shared Library Module Support Fam Zheng
2013-09-11 13:34 ` [Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path Fam Zheng
2013-09-11 13:41   ` Paolo Bonzini
2013-09-12  2:32     ` Fam Zheng
2013-09-11 14:59   ` Daniel P. Berrange
2013-09-12  1:57     ` Fam Zheng
2013-09-12  2:22     ` Fam Zheng
2013-09-11 16:38   ` Peter Maydell
2013-09-11 16:40     ` Paolo Bonzini
2013-09-11 16:43       ` Peter Maydell
2013-09-11 13:34 ` [Qemu-devel] [PATCH v6 2/8] rule.mak: allow per object cflags and libs Fam Zheng
2013-09-11 13:43   ` Paolo Bonzini
2013-09-12  2:52     ` Fam Zheng
2013-09-12  6:34       ` Paolo Bonzini
2013-09-12  7:12         ` Fam Zheng
2013-09-11 13:34 ` [Qemu-devel] [PATCH v6 3/8] Makefile: introduce common-obj-m and block-obj-m for DSO Fam Zheng
2013-09-11 20:01   ` Peter Maydell
2013-09-12  2:48     ` Fam Zheng
2013-09-12  2:50   ` Fam Zheng
2013-09-11 13:34 ` [Qemu-devel] [PATCH v6 4/8] module: implement module loading function Fam Zheng
2013-09-11 15:48   ` Daniel P. Berrange
2013-09-11 18:33     ` Alex Bligh
2013-09-11 18:46     ` Richard Henderson
2013-09-12  3:02       ` Fam Zheng
2013-09-12  5:36         ` Michael Tokarev
2013-09-12  9:13           ` Daniel P. Berrange
2013-09-12 11:59           ` Eric Blake
2013-09-12 12:44             ` Daniel P. Berrange
2013-09-11 13:34 ` [Qemu-devel] [PATCH v6 5/8] configure: introduce --enable-modules Fam Zheng
2013-09-11 13:46   ` Paolo Bonzini
2013-09-12  2:06     ` Fam Zheng
2013-09-11 13:34 ` [Qemu-devel] [PATCH v6 6/8] Makefile: install modules with "make install" Fam Zheng
2013-09-11 13:50   ` Paolo Bonzini
2013-09-12  2:00     ` Fam Zheng
2013-09-11 13:34 ` [Qemu-devel] [PATCH v6 7/8] .gitignore: ignore module related files (dll, so, mo) Fam Zheng
2013-09-11 13:34 ` [Qemu-devel] [PATCH v6 8/8] block: convert block drivers linked with libs to modules Fam Zheng
2013-09-11 15:41   ` Daniel P. Berrange [this message]
2013-09-12  2:07     ` Fam Zheng
2013-09-11 16:26 ` [Qemu-devel] [PATCH v6 0/8] Shared Library Module Support Peter Maydell
2013-09-12  3:08   ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130911154138.GC2293@redhat.com \
    --to=berrange@redhat.com \
    --cc=famz@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    --cc=vilanova@ac.upc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).