From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJmYA-0001ue-JN for qemu-devel@nongnu.org; Wed, 11 Sep 2013 11:41:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJmY6-0001Ma-SK for qemu-devel@nongnu.org; Wed, 11 Sep 2013 11:41:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJmY6-0001MV-Il for qemu-devel@nongnu.org; Wed, 11 Sep 2013 11:41:46 -0400 Date: Wed, 11 Sep 2013 16:41:38 +0100 From: "Daniel P. Berrange" Message-ID: <20130911154138.GC2293@redhat.com> References: <1378906448-15834-1-git-send-email-famz@redhat.com> <1378906448-15834-9-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1378906448-15834-9-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 8/8] block: convert block drivers linked with libs to modules Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: peter.maydell@linaro.org, mjt@tls.msk.ru, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, vilanova@ac.upc.edu, rth@twiddle.net On Wed, Sep 11, 2013 at 09:34:08PM +0800, Fam Zheng wrote: > The converted block drivers are: > > curl > iscsi > rbd > ssh > glusterfs > > no longer adds flags and libs for them to global variables, instead > create config-host.mak variables like FOO_CFLAGS and FOO_LIBS, which is > used as per object cflags and libs. > > Signed-off-by: Fam Zheng > --- > block/Makefile.objs | 11 ++++++++++- > configure | 33 +++++++++++++++------------------ > 2 files changed, 25 insertions(+), 19 deletions(-) After this is applied, I can no longer use http:/// URIs with the curl driver, if I do not build with '--enable-modules' passed to configure. $ ~/usr/qemu-git/bin/qemu-system-x86_64 -cdrom http://www.mirrorservice.org/sites/dl.fedoraproject.org/pub/fedora/linux//releases/19/Fedora/x86_64/os/images/boot.iso qemu-system-x86_64: -cdrom http://www.mirrorservice.org/sites/dl.fedoraproject.org/pub/fedora/linux//releases/19/Fedora/x86_64/os/images/boot.iso: Unknown protocol qemu-system-x86_64: -cdrom http://www.mirrorservice.org/sites/dl.fedoraproject.org/pub/fedora/linux//releases/19/Fedora/x86_64/os/images/boot.iso: could not open disk image http://www.mirrorservice.org/sites/dl.fedoraproject.org/pub/fedora/linux//releases/19/Fedora/x86_64/os/images/boot.iso: No such file or directory So it seems driver registration is broken in some way when modules aren't enabled at compile time. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|