From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55377)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1VJwDJ-0000BH-QF
	for qemu-devel@nongnu.org; Wed, 11 Sep 2013 22:01:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1VJwDD-0005uD-PP
	for qemu-devel@nongnu.org; Wed, 11 Sep 2013 22:00:57 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17455)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1VJwDD-0005u5-DY
	for qemu-devel@nongnu.org; Wed, 11 Sep 2013 22:00:51 -0400
Date: Thu, 12 Sep 2013 10:00:45 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20130912020045.GC9134@T430s.nay.redhat.com>
References: <1378906448-15834-1-git-send-email-famz@redhat.com>
	<1378906448-15834-7-git-send-email-famz@redhat.com>
	<5230751B.8090609@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5230751B.8090609@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 6/8] Makefile: install modules with
	"make install"
Reply-To: famz@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, mjt@tls.msk.ru, qemu-devel@nongnu.org, stefanha@redhat.com, vilanova@ac.upc.edu, rth@twiddle.net

On Wed, 09/11 15:50, Paolo Bonzini wrote:
> Il 11/09/2013 15:34, Fam Zheng ha scritto:
> > Install all the subdirs for modules under configure option "moddir".
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  Makefile | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/Makefile b/Makefile
> > index c50b4b3..ca84d32 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -360,6 +360,12 @@ install-datadir install-localstatedir
> >  ifneq ($(TOOLS),)
> >  	$(INSTALL_PROG) $(STRIP_OPT) $(TOOLS) "$(DESTDIR)$(bindir)"
> >  endif
> > +ifneq ($(CONFIG_MODULES),)
> 
> Perhaps modules-m instead of CONFIG_MODULES would be more clearer given
> the "for" line immediately below.

modules-m has things even configured without --enable-modules, I think we don't install .so here.

> 
> > +	for s in $(patsubst %.mo,%.so,$(modules-m)); do \
> 
> DSOSUF here.

OK.

Fam
> 
> > +		$(INSTALL_DIR) "$(DESTDIR)$(moddir)/$$(dirname $$s)"; \
> > +		$(INSTALL_PROG) $(STRIP_OPT) $$s "$(DESTDIR)$(moddir)/$$(dirname $$s)"; \
> 
> Paolo
> 
> > +	done
> > +endif
> >  ifneq ($(HELPERS-y),)
> >  	$(INSTALL_DIR) "$(DESTDIR)$(libexecdir)"
> >  	$(INSTALL_PROG) $(STRIP_OPT) $(HELPERS-y) "$(DESTDIR)$(libexecdir)"
> > 
>