From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VK6bh-0003wT-LW for qemu-devel@nongnu.org; Thu, 12 Sep 2013 09:06:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VK6bd-0005o5-At for qemu-devel@nongnu.org; Thu, 12 Sep 2013 09:06:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VK6bd-0005o0-3s for qemu-devel@nongnu.org; Thu, 12 Sep 2013 09:06:45 -0400 Date: Thu, 12 Sep 2013 15:06:34 +0200 From: Stefan Hajnoczi Message-ID: <20130912130634.GD18070@stefanha-thinkpad.redhat.com> References: <1378975657-5141-1-git-send-email-v.maffione@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1378975657-5141-1-git-send-email-v.maffione@gmail.com> Subject: Re: [Qemu-devel] [PATCH v3] e1000: NetClientInfo.receive_iov implemented List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vincenzo Maffione Cc: mst@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, pbonzini@redhat.com, g.lettieri@iet.unipi.it, rizzo@iet.unipi.it, afaerber@suse.de On Thu, Sep 12, 2013 at 10:47:37AM +0200, Vincenzo Maffione wrote: > This patch implements the NetClientInfo.receive_iov method for the > e1000 device emulation. In this way a network backend that uses > qemu_sendv_packet() can deliver the fragmented packet without > requiring an additional copy in the frontend/backend network code > (nc_sendv_compat() function). > > The existing method NetClientInfo.receive has been reimplemented > using the new method. > > Signed-off-by: Vincenzo Maffione > --- > hw/net/e1000.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++++---------- > 1 file changed, 58 insertions(+), 12 deletions(-) > > I propose this patch also because our research group (University of Pisa, > Department of Computer Engineering) is working on the e1000 device > (optimizations and paravirtual extensions) and we have patches to > support the VALE switch as a network backend (see > http://info.iet.unipi.it/~luigi/vale/). > The VALE backend uses qemu_sendv_packet() to send fragmented packets: For > this reason we think it could be interesting to better support these packets > with e1000. Thanks, applied to my net-next tree: https://github.com/stefanha/qemu/commits/net-next Stefan