From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55928) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VK7XX-0002cD-8A for qemu-devel@nongnu.org; Thu, 12 Sep 2013 10:06:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VK7XS-0006J4-9M for qemu-devel@nongnu.org; Thu, 12 Sep 2013 10:06:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VK7XS-0006Iy-15 for qemu-devel@nongnu.org; Thu, 12 Sep 2013 10:06:30 -0400 Date: Thu, 12 Sep 2013 15:06:09 +0100 From: "Daniel P. Berrange" Message-ID: <20130912140609.GM18793@redhat.com> References: <1378969499-15066-1-git-send-email-famz@redhat.com> <1378969499-15066-7-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1378969499-15066-7-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 6/8] Makefile: install modules with "make install" Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: peter.maydell@linaro.org, mjt@tls.msk.ru, qemu-devel@nongnu.org, alex@alex.org.uk, pbonzini@redhat.com, vilanova@ac.upc.edu, rth@twiddle.net On Thu, Sep 12, 2013 at 03:04:57PM +0800, Fam Zheng wrote: > Install all the subdirs for modules under configure option "moddir". > > Signed-off-by: Fam Zheng > --- > Makefile | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Makefile b/Makefile > index ef76967..00c2a52 100644 > --- a/Makefile > +++ b/Makefile > @@ -360,6 +360,12 @@ install-datadir install-localstatedir > ifneq ($(TOOLS),) > $(INSTALL_PROG) $(STRIP_OPT) $(TOOLS) "$(DESTDIR)$(bindir)" > endif > +ifneq ($(CONFIG_MODULES),) > + for s in $(patsubst %.mo,%(DSOSUF),$(modules-m)); do \ Typo, causing install failure: for s in block/iscsi(DSOSUF) block/curl(DSOSUF) block/rbd(DSOSUF) block/gluster(DSOSUF) block/ssh(DSOSUF); do \ install -d -m 0755 "/home/berrange/usr/qemu-git-mod/lib/qemu/$(dirname $s)"; \ libtool --quiet --mode=install install -c -m 0755 $s "/home/berrange/usr/qemu-git-mod/lib/qemu/$(dirname $s)"; \ done /bin/sh: -c: line 0: syntax error near unexpected token `(' /bin/sh: -c: line 0: `for s in block/iscsi(DSOSUF) block/curl(DSOSUF) block/rbd(DSOSUF) block/gluster(DSOSUF) block/ssh(DSOSUF); do \' make: *** [install] Error 1 Just s/%(DSOSUF)/%$(DSOSUF)/ I believe Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|