From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38877)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1VKIAi-0001JB-Eu
	for qemu-devel@nongnu.org; Thu, 12 Sep 2013 21:27:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1VKIAb-0000OZ-6X
	for qemu-devel@nongnu.org; Thu, 12 Sep 2013 21:27:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2175)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1VKIAa-0000OG-VH
	for qemu-devel@nongnu.org; Thu, 12 Sep 2013 21:27:37 -0400
Date: Fri, 13 Sep 2013 09:27:22 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20130913012722.GA17693@T430s.nay.redhat.com>
References: <1378969499-15066-1-git-send-email-famz@redhat.com>
	<1378969499-15066-7-git-send-email-famz@redhat.com>
	<20130912140609.GM18793@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130912140609.GM18793@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 6/8] Makefile: install modules with
	"make install"
Reply-To: famz@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: peter.maydell@linaro.org, mjt@tls.msk.ru, qemu-devel@nongnu.org, alex@alex.org.uk, pbonzini@redhat.com, vilanova@ac.upc.edu, rth@twiddle.net

On Thu, 09/12 15:06, Daniel P. Berrange wrote:
> On Thu, Sep 12, 2013 at 03:04:57PM +0800, Fam Zheng wrote:
> > Install all the subdirs for modules under configure option "moddir".
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  Makefile | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/Makefile b/Makefile
> > index ef76967..00c2a52 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -360,6 +360,12 @@ install-datadir install-localstatedir
> >  ifneq ($(TOOLS),)
> >  	$(INSTALL_PROG) $(STRIP_OPT) $(TOOLS) "$(DESTDIR)$(bindir)"
> >  endif
> > +ifneq ($(CONFIG_MODULES),)
> > +	for s in $(patsubst %.mo,%(DSOSUF),$(modules-m)); do \
> 
> Typo, causing install failure:
> 
> for s in block/iscsi(DSOSUF) block/curl(DSOSUF) block/rbd(DSOSUF) block/gluster(DSOSUF) block/ssh(DSOSUF); do \
> 	install -d -m 0755 "/home/berrange/usr/qemu-git-mod/lib/qemu/$(dirname $s)"; \
> 	libtool --quiet --mode=install install -c -m 0755  $s "/home/berrange/usr/qemu-git-mod/lib/qemu/$(dirname $s)"; \
> done
> /bin/sh: -c: line 0: syntax error near unexpected token `('
> /bin/sh: -c: line 0: `for s in block/iscsi(DSOSUF) block/curl(DSOSUF) block/rbd(DSOSUF) block/gluster(DSOSUF) block/ssh(DSOSUF); do \'
> make: *** [install] Error 1
> 
> 
> Just  s/%(DSOSUF)/%$(DSOSUF)/ I believe
> 
Yes, thanks for catching.

Fam