From: Christoffer Dall <christoffer.dall@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Patch Tracking <patches@linaro.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>
Subject: Re: [Qemu-devel] [PATCH 4/4] arm: vgic device control api support
Date: Thu, 12 Sep 2013 22:15:25 -0700 [thread overview]
Message-ID: <20130913051525.GA30894@cbox> (raw)
In-Reply-To: <CAFEAcA-DMKBkPCJ+YKrj_NshvidYzeQpnKZ0LQjxn8sY6GC3tg@mail.gmail.com>
On Fri, Sep 06, 2013 at 02:34:40PM +0100, Peter Maydell wrote:
> On 23 August 2013 20:41, Christoffer Dall <christoffer.dall@linaro.org> wrote:
> > Support creating the ARM vgic device through the device control API and
> > setting the base address for the distributor and cpu interfaces in KVM
> > VMs using this API.
> >
> > Because the older KVM_CREATE_IRQCHIP interface needs the irq chip to be
> > created prior to creating the VCPUs, we first test if if can use the
>
> "if we"
>
Peter,
Thanks for your review comments and pointers on how to fix. Much
appreciated. I've addressed your comments and will get a new series out
asap.
-Christoffer
prev parent reply other threads:[~2013-09-13 5:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 19:40 [Qemu-devel] [PATCH 0/4] Create ARM KVM VGIC with device control API Christoffer Dall
2013-08-23 19:40 ` [Qemu-devel] [PATCH 1/4] kvm: Update headers for device control api Christoffer Dall
2013-08-24 10:31 ` Peter Maydell
2013-08-23 19:41 ` [Qemu-devel] [PATCH 2/4] kvm: Introduce kvm_arch_irqchip_create Christoffer Dall
2013-09-06 13:08 ` Peter Maydell
2013-08-23 19:41 ` [Qemu-devel] [PATCH 3/4] kvm: Common device control API functions Christoffer Dall
2013-09-06 13:15 ` Peter Maydell
2013-08-23 19:41 ` [Qemu-devel] [PATCH 4/4] arm: vgic device control api support Christoffer Dall
2013-09-06 13:34 ` Peter Maydell
2013-09-13 5:15 ` Christoffer Dall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130913051525.GA30894@cbox \
--to=christoffer.dall@linaro.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linaro-kernel@lists.linaro.org \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).