From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35841)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <christoffer.dall@linaro.org>) id 1VKLj0-0005XS-Hj
	for qemu-devel@nongnu.org; Fri, 13 Sep 2013 01:15:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <christoffer.dall@linaro.org>) id 1VKLiu-0006vk-HJ
	for qemu-devel@nongnu.org; Fri, 13 Sep 2013 01:15:22 -0400
Received: from mail-pa0-f43.google.com ([209.85.220.43]:59491)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <christoffer.dall@linaro.org>) id 1VKLiu-0006vW-B4
	for qemu-devel@nongnu.org; Fri, 13 Sep 2013 01:15:16 -0400
Received: by mail-pa0-f43.google.com with SMTP id hz10so2057300pad.30
	for <qemu-devel@nongnu.org>; Thu, 12 Sep 2013 22:15:15 -0700 (PDT)
Date: Thu, 12 Sep 2013 22:15:25 -0700
From: Christoffer Dall <christoffer.dall@linaro.org>
Message-ID: <20130913051525.GA30894@cbox>
References: <1377286862-5879-1-git-send-email-christoffer.dall@linaro.org>
	<1377286862-5879-5-git-send-email-christoffer.dall@linaro.org>
	<CAFEAcA-DMKBkPCJ+YKrj_NshvidYzeQpnKZ0LQjxn8sY6GC3tg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA-DMKBkPCJ+YKrj_NshvidYzeQpnKZ0LQjxn8sY6GC3tg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] arm: vgic device control api support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Patch Tracking <patches@linaro.org>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>

On Fri, Sep 06, 2013 at 02:34:40PM +0100, Peter Maydell wrote:
> On 23 August 2013 20:41, Christoffer Dall <christoffer.dall@linaro.org> wrote:
> > Support creating the ARM vgic device through the device control API and
> > setting the base address for the distributor and cpu interfaces in KVM
> > VMs using this API.
> >
> > Because the older KVM_CREATE_IRQCHIP interface needs the irq chip to be
> > created prior to creating the VCPUs, we first test if if can use the
> 
> "if we"
> 
Peter,

Thanks for your review comments and pointers on how to fix.  Much
appreciated.  I've addressed your comments and will get a new series out
asap.

-Christoffer