From: Fam Zheng <famz@redhat.com>
To: Alex Bligh <alex@alex.org.uk>
Cc: peter.maydell@linaro.org, mjt@tls.msk.ru, qemu-devel@nongnu.org,
pbonzini@redhat.com, vilanova@ac.upc.edu, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v8 5/9] module: implement module loading function
Date: Fri, 13 Sep 2013 18:05:35 +0800 [thread overview]
Message-ID: <20130913100535.GB6065@T430s.nay.redhat.com> (raw)
In-Reply-To: <1C973DFB-D08C-495D-A797-F93CC6BE2BE4@alex.org.uk>
On Fri, 09/13 10:56, Alex Bligh wrote:
>
> On 13 Sep 2013, at 09:38, Fam Zheng wrote:
>
> > Added three types of modules:
> >
> > typedef enum {
> > MODULE_LOAD_BLOCK = 0,
> > MODULE_LOAD_UI,
> > MODULE_LOAD_NET,
> > MODULE_LOAD_MAX,
> > } module_load_type;
> >
> > and their loading function:
>
> What is the advantage of this enum and having
> different types of module at all? If they are
> all built together, why can't they all live
> together in the same directory?
>
> Seems like an overcomplication.
>
They anyway need to be grouped: block drivers are almost always loaded, but not
ui, or net (although they're not modulized in this series), and they shouldn't
be loaded, from example by qemu-img, because of missing necessary functions.
For this reason, I don't think subdirecotry is an overcomplication over file
name prefix/postfix, or arrays of file name lists.
Fam
next prev parent reply other threads:[~2013-09-13 10:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 8:38 [Qemu-devel] [PATCH v8 0/9] Shared Library Module Support Fam Zheng
2013-09-13 8:38 ` [Qemu-devel] [PATCH v8 1/9] ui/Makefile.objs: delete unnecessary cocoa.o dependency Fam Zheng
2013-09-13 8:38 ` [Qemu-devel] [PATCH v8 2/9] make.rule: fix $(obj) to a real relative path Fam Zheng
2013-09-13 8:38 ` [Qemu-devel] [PATCH v8 3/9] rule.mak: allow per object cflags and libs Fam Zheng
2013-09-13 8:38 ` [Qemu-devel] [PATCH v8 4/9] build-sys: introduce common-obj-m and block-obj-m for DSO Fam Zheng
2013-09-13 8:38 ` [Qemu-devel] [PATCH v8 5/9] module: implement module loading function Fam Zheng
2013-09-13 9:56 ` Alex Bligh
2013-09-13 10:02 ` Paolo Bonzini
2013-09-13 10:38 ` Alex Bligh
2013-09-13 10:05 ` Fam Zheng [this message]
2013-09-13 8:38 ` [Qemu-devel] [PATCH v8 6/9] module: add configurable module whitelist Fam Zheng
2013-09-13 9:03 ` Daniel P. Berrange
2013-09-13 9:57 ` Fam Zheng
2013-09-13 8:38 ` [Qemu-devel] [PATCH v8 7/9] Makefile: install modules with "make install" Fam Zheng
2013-09-13 8:38 ` [Qemu-devel] [PATCH v8 8/9] .gitignore: ignore module related files (dll, so, mo) Fam Zheng
2013-09-13 8:38 ` [Qemu-devel] [PATCH v8 9/9] block: convert block drivers linked with libs to modules Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130913100535.GB6065@T430s.nay.redhat.com \
--to=famz@redhat.com \
--cc=alex@alex.org.uk \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).