qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Fix test 038
Date: Fri, 13 Sep 2013 12:07:56 +0200	[thread overview]
Message-ID: <20130913100756.GD2804@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1379061432-16841-1-git-send-email-mreitz@redhat.com>

Am 13.09.2013 um 10:37 hat Max Reitz geschrieben:
> Test 038 uses asynchronous I/O, resulting (potentially) in a different
> output for every run (regarding the order of the I/O accesses). This can
> be fixed by simply sorting the I/O access messages, since their order is
> irrelevant anyway (for this asynchonous I/O).
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  tests/qemu-iotests/038     |  3 ++-
>  tests/qemu-iotests/038.out | 10 +++++-----
>  2 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/qemu-iotests/038 b/tests/qemu-iotests/038
> index 36125ea..90de1a7 100755
> --- a/tests/qemu-iotests/038
> +++ b/tests/qemu-iotests/038
> @@ -95,7 +95,8 @@ function overlay_io()
>  }
>  
>  overlay_io | $QEMU_IO $TEST_IMG | _filter_qemu_io |\
> -	sed -e 's/bytes at offset [0-9]*/bytes at offset XXX/g'
> +    sed -e 's/bytes at offset [0-9]*/bytes at offset XXX/g' \
> +    -e 's/qemu-io> //g' | paste - - | sort | tr '\t' '\n'

Awesome. :-)

Thanks, applied to the block branch.

Kevin

  reply	other threads:[~2013-09-13 10:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-13  8:37 [Qemu-devel] [PATCH] qemu-iotests: Fix test 038 Max Reitz
2013-09-13 10:07 ` Kevin Wolf [this message]
2013-09-13 12:23 ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130913100756.GD2804@dhcp-200-207.str.redhat.com \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).