From: Luiz Capitulino <lcapitulino@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/6] QMP: add scripts/qmp
Date: Fri, 13 Sep 2013 13:52:40 -0400 [thread overview]
Message-ID: <20130913135240.6d220ce1@redhat.com> (raw)
In-Reply-To: <5230EB0C.7050507@redhat.com>
On Wed, 11 Sep 2013 16:13:32 -0600
Eric Blake <eblake@redhat.com> wrote:
> On 09/11/2013 04:08 PM, Eric Blake wrote:
> > On 09/11/2013 02:52 PM, Luiz Capitulino wrote:
> >> Populate it with all scripts stored in QMP/.
> >>
> >> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
>
> > Reviewed-by: Eric Blake <eblake@redhat.com>
> >
> > Repeat after me:
> > git config diff.renames true
> >
> > at which point, this commit is much more compact and reviewable:
Done.
> Oh, and while testing your patch:
>
> <stdin>:1854: trailing whitespace.
>
> <stdin>:2054: trailing whitespace.
> #
> warning: 2 lines add whitespace errors.
>
> One instance from qmp-shell; the other from qmp.py. It's okay if you
> touch those up as part of this rename (again, the diff.renames true bit
> will highlight those two changes, rather than showing the complete file
> as a delete and addition).
Fixed.
next prev parent reply other threads:[~2013-09-13 17:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 20:52 [Qemu-devel] [PATCH 0/6] QMP: re-organize documentation Luiz Capitulino
2013-09-11 20:52 ` [Qemu-devel] [PATCH 1/6] QMP: add scripts/qmp Luiz Capitulino
2013-09-11 22:08 ` Eric Blake
2013-09-11 22:13 ` Eric Blake
2013-09-13 17:52 ` Luiz Capitulino [this message]
2013-09-11 20:52 ` [Qemu-devel] [PATCH 2/6] QMP: fix qmp-commands.txt generation path Luiz Capitulino
2013-09-11 22:09 ` Eric Blake
2013-09-11 20:52 ` [Qemu-devel] [PATCH 3/6] QMP: QMP/ -> docs/qmp/ Luiz Capitulino
2013-09-11 22:15 ` Eric Blake
2013-09-11 20:52 ` [Qemu-devel] [PATCH 4/6] QMP: Update README file Luiz Capitulino
2013-09-11 23:13 ` Eric Blake
2013-09-11 20:52 ` [Qemu-devel] [PATCH 5/6] QMP: Update qmp-spec.txt Luiz Capitulino
2013-09-11 23:27 ` Eric Blake
2013-09-13 17:54 ` Luiz Capitulino
2013-09-13 18:00 ` Eric Blake
2013-09-11 20:52 ` [Qemu-devel] [PATCH 6/6] QMP: qmp-events.txt: minor fixes Luiz Capitulino
2013-09-11 23:30 ` Eric Blake
2013-09-13 18:01 ` Luiz Capitulino
2013-09-13 18:16 ` Eric Blake
2013-09-13 18:20 ` Luiz Capitulino
-- strict thread matches above, loose matches on Subject: below --
2013-09-13 18:11 [Qemu-devel] [PATCH v2 0/6] QMP: re-organize documentation Luiz Capitulino
2013-09-13 18:11 ` [Qemu-devel] [PATCH 1/6] QMP: add scripts/qmp Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130913135240.6d220ce1@redhat.com \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).