From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36043)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VKXY2-0002wi-Jr
	for qemu-devel@nongnu.org; Fri, 13 Sep 2013 13:52:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VKXXw-0007Jm-O8
	for qemu-devel@nongnu.org; Fri, 13 Sep 2013 13:52:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9999)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VKXXw-0007I9-GP
	for qemu-devel@nongnu.org; Fri, 13 Sep 2013 13:52:44 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8DHqgAU022609
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 13 Sep 2013 13:52:42 -0400
Date: Fri, 13 Sep 2013 13:52:40 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130913135240.6d220ce1@redhat.com>
In-Reply-To: <5230EB0C.7050507@redhat.com>
References: <1378932737-13422-1-git-send-email-lcapitulino@redhat.com>
	<1378932737-13422-2-git-send-email-lcapitulino@redhat.com>
	<5230E9FB.5080101@redhat.com> <5230EB0C.7050507@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/6] QMP: add scripts/qmp
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com

On Wed, 11 Sep 2013 16:13:32 -0600
Eric Blake <eblake@redhat.com> wrote:

> On 09/11/2013 04:08 PM, Eric Blake wrote:
> > On 09/11/2013 02:52 PM, Luiz Capitulino wrote:
> >> Populate it with all scripts stored in QMP/.
> >>
> >> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> 
> > Reviewed-by: Eric Blake <eblake@redhat.com>
> > 
> > Repeat after me:
> > git config diff.renames true
> > 
> > at which point, this commit is much more compact and reviewable:

Done.

> Oh, and while testing your patch:
> 
> <stdin>:1854: trailing whitespace.
> 
> <stdin>:2054: trailing whitespace.
> #
> warning: 2 lines add whitespace errors.
> 
> One instance from qmp-shell; the other from qmp.py.  It's okay if you
> touch those up as part of this rename (again, the diff.renames true bit
> will highlight those two changes, rather than showing the complete file
> as a delete and addition).

Fixed.