From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37466)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VKXgX-0006fH-Ns
	for qemu-devel@nongnu.org; Fri, 13 Sep 2013 14:01:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VKXgO-00012i-MW
	for qemu-devel@nongnu.org; Fri, 13 Sep 2013 14:01:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:7942)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VKXgO-00012e-FT
	for qemu-devel@nongnu.org; Fri, 13 Sep 2013 14:01:28 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8DI1Rn1012461
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 13 Sep 2013 14:01:27 -0400
Date: Fri, 13 Sep 2013 14:01:25 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130913140125.75a32a72@redhat.com>
In-Reply-To: <5230FD28.3030806@redhat.com>
References: <1378932737-13422-1-git-send-email-lcapitulino@redhat.com>
	<1378932737-13422-7-git-send-email-lcapitulino@redhat.com>
	<5230FD28.3030806@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 6/6] QMP: qmp-events.txt: minor fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com

On Wed, 11 Sep 2013 17:30:48 -0600
Eric Blake <eblake@redhat.com> wrote:

> On 09/11/2013 02:52 PM, Luiz Capitulino wrote:
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> >  docs/qmp/qmp-events.txt | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt
> > index 39b6016..1e91f45 100644
> > --- a/docs/qmp/qmp-events.txt
> > +++ b/docs/qmp/qmp-events.txt
> > @@ -1,4 +1,4 @@
> > -                   QEMU Monitor Protocol Events
> > +                   QEMU Machine Protocol Events
> >                     ============================
> >  
> >  BALLOON_CHANGE
> > @@ -173,7 +173,7 @@ Data:
> >    "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
> >  
> >  NIC_RX_FILTER_CHANGED
> > ------------------
> > +---------------------
> >  
> >  The event is emitted once until the query command is executed,
> >  the first event will always be emitted.
> > 
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> But incomplete.  DEVICE_DELETED has a too-long delimiter, GUEST_PANICKED
> is out of order,

Fixed those.

> and it's probably worth splitting SPICE_CONNECTED and
> SPICE_DISCONNECTED into separate sections (matching VNC_CONNECTED and
> VNC_DISCONNECTED).

This probably better done in a different patch. Will left for another day.