From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41730) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKXyx-0004gS-37 for qemu-devel@nongnu.org; Fri, 13 Sep 2013 14:20:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKXyq-0006jV-NB for qemu-devel@nongnu.org; Fri, 13 Sep 2013 14:20:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24648) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKXyq-0006jO-ES for qemu-devel@nongnu.org; Fri, 13 Sep 2013 14:20:32 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8DIKVVu030323 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 13 Sep 2013 14:20:32 -0400 Date: Fri, 13 Sep 2013 14:20:30 -0400 From: Luiz Capitulino Message-ID: <20130913142030.28e12559@redhat.com> In-Reply-To: <52335664.8090102@redhat.com> References: <1378932737-13422-1-git-send-email-lcapitulino@redhat.com> <1378932737-13422-7-git-send-email-lcapitulino@redhat.com> <5230FD28.3030806@redhat.com> <20130913140125.75a32a72@redhat.com> <52335664.8090102@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/6] QMP: qmp-events.txt: minor fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, armbru@redhat.com On Fri, 13 Sep 2013 12:16:04 -0600 Eric Blake wrote: > On 09/13/2013 12:01 PM, Luiz Capitulino wrote: > > On Wed, 11 Sep 2013 17:30:48 -0600 > > Eric Blake wrote: > > > > > >> and it's probably worth splitting SPICE_CONNECTED and > >> SPICE_DISCONNECTED into separate sections (matching VNC_CONNECTED and > >> VNC_DISCONNECTED). > > > > This probably better done in a different patch. Will left for another day. > > In fact, such a better day is probably during the conversion from txt to > QMP (now that we have a proposal for how to use a discriminated qmp > union type for representing event types). Yeah.