From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VL5tQ-0006Rg-O5 for qemu-devel@nongnu.org; Sun, 15 Sep 2013 02:33:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VL5tL-0004e6-Sy for qemu-devel@nongnu.org; Sun, 15 Sep 2013 02:33:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38099) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VL5tL-0004e1-La for qemu-devel@nongnu.org; Sun, 15 Sep 2013 02:33:07 -0400 Date: Sun, 15 Sep 2013 09:35:15 +0300 From: "Michael S. Tsirkin" Message-ID: <20130915063515.GA29086@redhat.com> References: <1379073525-20995-1-git-send-email-hpoussin@reactos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1379073525-20995-1-git-send-email-hpoussin@reactos.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] pci: remove explicit check to 64K ioport size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Herv=E9?= Poussineau Cc: qemu-devel@nongnu.org On Fri, Sep 13, 2013 at 01:58:44PM +0200, Herv=E9 Poussineau wrote: > This check is useless, as bigger addresses will be ignored when > added to 'io' MemoryRegion, which has a size of 64K. >=20 > However, some architectures don't use the 'io' MemoryRegion, like > the alpha and versatile platforms. They create a PCI I/O region > bigger than 64K, so let them handle PCI I/O BARs in the higher range. >=20 > Signed-off-by: Herv=E9 Poussineau > --- > hw/pci/pci.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/hw/pci/pci.c b/hw/pci/pci.c > index d00682e..a8e2b29 100644 > --- a/hw/pci/pci.c > +++ b/hw/pci/pci.c > @@ -1028,8 +1028,7 @@ static pcibus_t pci_bar_address(PCIDevice *d, > } > new_addr =3D pci_get_long(d->config + bar) & ~(size - 1); > last_addr =3D new_addr + size - 1; > - /* NOTE: we have only 64K ioports on PC */ > - if (last_addr <=3D new_addr || new_addr =3D=3D 0 || last_addr = > UINT16_MAX) { > + if (last_addr <=3D new_addr || new_addr =3D=3D 0) { > return PCI_BAR_UNMAPPED; > } > return new_addr; > --=20 > 1.7.10.4 We still didn't fix the overlap for PCI BARs properly so it looks like the following is needed on top. Could you please check whether this works for you on versatile/alpha? diff --git a/hw/pci/pci.c b/hw/pci/pci.c index d452135..3118854 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1028,7 +1028,10 @@ static pcibus_t pci_bar_address(PCIDevice *d, } new_addr =3D pci_get_long(d->config + bar) & ~(size - 1); last_addr =3D new_addr + size - 1; - if (last_addr <=3D new_addr || new_addr =3D=3D 0) { + /* Check if BAR is being sized explicitly. + * TODO: make priorities correct and remove this work around. + */ + if (last_addr <=3D new_addr || new_addr =3D=3D 0 || last_addr >=3D= UINT32_MAX) { return PCI_BAR_UNMAPPED; } return new_addr;