From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"Anthony Liguori" <anthony@codemonkey.ws>
Subject: [Qemu-devel] [PATCH] qom: helper macro for adding read-only properties
Date: Sun, 15 Sep 2013 20:23:31 +0300 [thread overview]
Message-ID: <20130915172331.GA2821@redhat.com> (raw)
Add a helper macro for adding read-only properties, that works in the
common case where the value is a constant.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
I'm using this patch in my acpi work - any objections
to applying it on my tree?
include/qom/object.h | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/include/qom/object.h b/include/qom/object.h
index 1a7b71a..4787de6 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -17,6 +17,7 @@
#include <glib.h>
#include <stdint.h>
#include <stdbool.h>
+#include "qemu/typedefs.h"
#include "qemu/queue.h"
struct Visitor;
@@ -792,6 +793,26 @@ void object_property_add(Object *obj, const char *name, const char *type,
ObjectPropertyRelease *release,
void *opaque, struct Error **errp);
+/* Add a property that is an integer constant. */
+#define OBJECT_ADD_PROP_CONST(obj, name, value) \
+ do { \
+ void OBJECT_ADD_PROP_GET(Object *OBJECT_ADD_PROP_OBJ, \
+ struct Visitor *OBJECT_ADD_PROP_VISITOR, \
+ void *OBJECT_ADD_PROP_OPAQUE, \
+ const char *OBJECT_ADD_PROP_NAME, \
+ struct Error **OBJECT_ADD_PROP_VALUE_ERR) \
+ { \
+ int64_t OBJECT_ADD_PROP_VALUE = value; \
+ \
+ visit_type_int64(OBJECT_ADD_PROP_VISITOR, \
+ &OBJECT_ADD_PROP_VALUE, \
+ OBJECT_ADD_PROP_NAME, \
+ OBJECT_ADD_PROP_VALUE_ERR); \
+ } \
+ object_property_add(obj, name, "int", OBJECT_ADD_PROP_GET, \
+ NULL, NULL, NULL, NULL); \
+ } while (0)
+
void object_property_del(Object *obj, const char *name, struct Error **errp);
/**
--
MST
next reply other threads:[~2013-09-15 17:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-15 17:23 Michael S. Tsirkin [this message]
2013-09-15 17:54 ` [Qemu-devel] [PATCH] qom: helper macro for adding read-only properties Peter Maydell
2013-09-15 20:06 ` Michael S. Tsirkin
2013-09-16 6:32 ` Andreas Färber
2013-09-16 12:33 ` Michael S. Tsirkin
2013-09-16 15:24 ` Andreas Färber
2013-09-16 15:41 ` Paolo Bonzini
2013-09-16 15:48 ` Michael S. Tsirkin
2013-09-16 15:56 ` Paolo Bonzini
2013-09-16 16:01 ` Michael S. Tsirkin
2013-09-16 16:07 ` Paolo Bonzini
2013-09-16 16:51 ` Michael S. Tsirkin
2013-09-16 17:03 ` Paolo Bonzini
2013-09-16 16:07 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130915172331.GA2821@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).