From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51685)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VLGD9-00084q-Kc
	for qemu-devel@nongnu.org; Sun, 15 Sep 2013 13:34:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VLGD3-0005ry-KY
	for qemu-devel@nongnu.org; Sun, 15 Sep 2013 13:34:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46807)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VLGD3-0005rs-B5
	for qemu-devel@nongnu.org; Sun, 15 Sep 2013 13:34:09 -0400
Date: Sun, 15 Sep 2013 20:36:16 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130915173615.GA4971@redhat.com>
References: <1379256713-13197-1-git-send-email-peter.maydell@linaro.org>
	<20130915152427.GB18549@redhat.com>
	<CAFEAcA99bmD7sYcmeHKQti3=wJ_egpT4mJUDDO5PKqRDxYP9mw@mail.gmail.com>
	<20130915170733.GA20380@redhat.com>
	<CAFEAcA9FgUAZ2cqMX_MQmpg8FUVCWj+HJ+c0vx2VSwhL-nhhiA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA9FgUAZ2cqMX_MQmpg8FUVCWj+HJ+c0vx2VSwhL-nhhiA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] docs/memory.txt: Clarify and expand
 priority/overlap documentation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Marcel Apfelbaum <marcel.a@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Patch Tracking <patches@linaro.org>

On Sun, Sep 15, 2013 at 06:29:51PM +0100, Peter Maydell wrote:
> On 15 September 2013 18:07, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Sun, Sep 15, 2013 at 05:55:54PM +0100, Peter Maydell wrote:
> >> On 15 September 2013 16:24, Michael S. Tsirkin <mst@redhat.com> wrote:
> >> > On Sun, Sep 15, 2013 at 03:51:53PM +0100, Peter Maydell wrote:
> >> >>  The memory core uses the following rules to select a memory region when the
> >> >> @@ -93,8 +136,11 @@ guest accesses an address:
> >> >>    - if the subregion is a leaf (RAM or MMIO), the search terminates
> >> >
> >> > Maybe add
> >> > "And the leaf is selected"
> >>
> >> Not sure what you mean by "selected" here.
> >
> > Well search terminates but what is the result?
> > It says "to select a memory region"
> > so for the result I said "is selected".
> 
> Oh, I see. I thought you were suggesting "if the subregion is a leaf
> and the leaf is selected, the search terminates"...
> 
> My suggested text below uses the phrasing "the search terminates
> with X", so perhaps "the search terminates with this leaf region" ?
> Better, make both of them be "the search terminates, returning X".
> 
> -- PMM

Sounds good.