From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLx9O-0006nW-2Z for qemu-devel@nongnu.org; Tue, 17 Sep 2013 11:25:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VLx9I-0008IZ-3V for qemu-devel@nongnu.org; Tue, 17 Sep 2013 11:25:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLx9H-0008I3-QO for qemu-devel@nongnu.org; Tue, 17 Sep 2013 11:25:08 -0400 Date: Tue, 17 Sep 2013 18:27:18 +0300 From: "Michael S. Tsirkin" Message-ID: <20130917152718.GA20105@redhat.com> References: <1376659114-6630-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1376659114-6630-1-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/7] smbios cleanup & nicer defaults for type 1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: armbru@redhat.com Cc: aliguori@us.ibm.com, lersek@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com On Fri, Aug 16, 2013 at 03:18:27PM +0200, armbru@redhat.com wrote: > From: Markus Armbruster > > This gets rid of one of the last get_param_value() users, makes > multiple -smbios work sanely, cleans up the gross side effect in > qemu_uuid_parse(), and more. Topped off with a little feature in the > last patch. > > v2: Rebase, only last patch had conflicts OK my thinking at this point is: patches 1-6 are ready Any objections? patch 7 - I would prefer some way to explicitly set default smbios manufacturer/version in machine type and set these from machine type, instead of the smbios_type1_defaults boolean. Would you like - me to apply 1-6 and keep working on 7? - wait for you to repost v3? - look for another maintainer to take patchset as is (if someone cares to, I won't object)? > Markus Armbruster (7): > smbios: Normalize smbios_entry_add()'s error handling to exit(1) > smbios: Convert to QemuOpts > smbios: Improve diagnostics for conflicting entries > smbios: Make multiple -smbios type= accumulate sanely > smbios: Factor out smbios_maybe_add_str() > vl: Set current_machine early > smbios: Set system manufacturer, product & version by default > > arch_init.c | 9 +- > hw/i386/pc.c | 6 +- > hw/i386/pc_piix.c | 5 + > hw/i386/pc_q35.c | 3 + > hw/i386/smbios.c | 349 ++++++++++++++++++++++++++++++++------------- > include/hw/i386/pc.h | 1 + > include/hw/i386/smbios.h | 7 +- > include/sysemu/arch_init.h | 2 +- > include/sysemu/sysemu.h | 1 + > vl.c | 8 +- > 10 files changed, 276 insertions(+), 115 deletions(-) > > -- > 1.8.1.4 >