From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMIDa-0004WX-Ou for qemu-devel@nongnu.org; Wed, 18 Sep 2013 09:55:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMIDQ-0005Qk-9k for qemu-devel@nongnu.org; Wed, 18 Sep 2013 09:54:58 -0400 Received: from mail-ea0-x22d.google.com ([2a00:1450:4013:c01::22d]:61724) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMIDQ-0005Qg-37 for qemu-devel@nongnu.org; Wed, 18 Sep 2013 09:54:48 -0400 Received: by mail-ea0-f173.google.com with SMTP id g10so3484814eak.32 for ; Wed, 18 Sep 2013 06:54:47 -0700 (PDT) Date: Wed, 18 Sep 2013 15:54:42 +0200 From: Stefan Hajnoczi Message-ID: <20130918135442.GD25444@stefanha-thinkpad.redhat.com> References: <1377573663-16727-1-git-send-email-pingfank@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1377573663-16727-1-git-send-email-pingfank@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v3 0/4] timers thread-safe stuff List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Ping Fan Cc: Kevin Wolf , Alex Bligh , Jan Kiszka , qemu-devel@nongnu.org, Stefan Hajnoczi , Paolo Bonzini On Tue, Aug 27, 2013 at 11:20:59AM +0800, Liu Ping Fan wrote: > Saw the Alex's patches has been merged, rebase mine onto his. > > v3: > 1. rename seqlock_read_check as seqlock_read_retry > 2. Document timerlist were protected by BQL, and discard private lock around "qemu_event_wait(tl->ev)". > > v2: > 1. fix comment in commit and code > 2. fix race issue for qemu_clock_enable(foo,disable) > > > Liu Ping Fan (2): > timer: protect timers_state's clock with seqlock > timer: make qemu_clock_enable sync between disable and timer's cb > > Paolo Bonzini (2): > seqlock: introduce read-write seqlock > qemu-thread: add QemuEvent > > cpus.c | 36 +++++++++++--- > include/qemu/seqlock.h | 72 +++++++++++++++++++++++++++ > include/qemu/thread-posix.h | 8 +++ > include/qemu/thread-win32.h | 4 ++ > include/qemu/thread.h | 7 +++ > include/qemu/timer.h | 4 ++ > qemu-timer.c | 20 +++++++- > util/qemu-thread-posix.c | 116 ++++++++++++++++++++++++++++++++++++++++++++ > util/qemu-thread-win32.c | 26 ++++++++++ > 9 files changed, 286 insertions(+), 7 deletions(-) > create mode 100644 include/qemu/seqlock.h Ping Fan: Can you send a final version that addresses Alex's request for documentation? Otherwise we're ready to go. Stefan