From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58961)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VMZZs-0000rc-6u
	for qemu-devel@nongnu.org; Thu, 19 Sep 2013 04:27:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VMZZh-0007wo-70
	for qemu-devel@nongnu.org; Thu, 19 Sep 2013 04:27:08 -0400
Received: from mail-ee0-x231.google.com ([2a00:1450:4013:c00::231]:61263)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VMZZg-0007wf-W2
	for qemu-devel@nongnu.org; Thu, 19 Sep 2013 04:26:57 -0400
Received: by mail-ee0-f49.google.com with SMTP id d41so3996065eek.36
	for <qemu-devel@nongnu.org>; Thu, 19 Sep 2013 01:26:56 -0700 (PDT)
Date: Thu, 19 Sep 2013 10:26:53 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130919082653.GC22814@stefanha-thinkpad.redhat.com>
References: <20130917124413.GA822@stefanha-thinkpad.str.redhat.com>
	<20130918150527.GA5025@irqsave.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20130918150527.GA5025@irqsave.net>
Subject: Re: [Qemu-devel] Merging the quorum block driver
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Wed, Sep 18, 2013 at 05:05:27PM +0200, Benoît Canet wrote:
> Le Tuesday 17 Sep 2013 à 14:44:13 (+0200), Stefan Hajnoczi a écrit :
> > Hi Benoit,
> > Kevin and I had a chance to chat face-to-face and we discussed what
> > concrete changes are necessary to merge quorum (without solving all the
> > other block layers problems at once).
> > 
> > I think quorum could be merged relatively quickly (and without massive
> > BlockFilter investments) by changing the following:
> > 
> > 1. Defining children on the command-line
> > 
> > Existing "filter" drivers use the protocol filename to embed their
> > children, for example the blkverify driver.  This is a big hack because
> > we have no proper syntax or escaping for the embedded drive definitions
> > in the file= option.
> > 
> > This was one of the main arguments against merging quorum.  Now that
> > Kevin has implemented driver-specific open options (see
> > block/qcow2.c:qcow2_runtime_opts), it is possible for the quorum driver
> > to open children specific on the command-line:
> > 
> >   -drive if=none,file.driver=quorum,format=raw,\
> >          file.children0.file=/nfs1/test.qcow2,\
> >          file.children1.file=/nfs2/test.qcow2,\
> >          file.children2.file=/nfs3/test.qcow2
> 
> Hello Stefan,
> 
> I started writing the code.
> 
> How would the quorum treshold be specified with this command line style ?

Kevin can correct me but I think:

  -drive ...,file.vote_threshold=2

BlockDrivers can have custom options.  The voting threshold is a good
example.

quorum_open() can check for "vote_threshold" in its options qdict.

Stefan