From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMdlv-0007p8-59 for qemu-devel@nongnu.org; Thu, 19 Sep 2013 08:55:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMdlp-0003tn-0R for qemu-devel@nongnu.org; Thu, 19 Sep 2013 08:55:51 -0400 Received: from nodalink.pck.nerim.net ([62.212.105.220]:36979 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMdlo-0003tX-MS for qemu-devel@nongnu.org; Thu, 19 Sep 2013 08:55:44 -0400 Date: Thu, 19 Sep 2013 14:55:36 +0200 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20130919125536.GA12498@irqsave.net> References: <20130917124413.GA822@stefanha-thinkpad.str.redhat.com> <20130918150527.GA5025@irqsave.net> <20130919082653.GC22814@stefanha-thinkpad.redhat.com> <20130919085750.GA3631@dhcp-200-207.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20130919085750.GA3631@dhcp-200-207.str.redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] Merging the quorum block driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: =?iso-8859-1?Q?Beno=EEt?= Canet , Stefan Hajnoczi , qemu-devel@nongnu.org, Stefan Hajnoczi Le Thursday 19 Sep 2013 =E0 10:57:50 (+0200), Kevin Wolf a =E9crit : > Am 19.09.2013 um 10:26 hat Stefan Hajnoczi geschrieben: > > On Wed, Sep 18, 2013 at 05:05:27PM +0200, Beno=EEt Canet wrote: > > > Le Tuesday 17 Sep 2013 =E0 14:44:13 (+0200), Stefan Hajnoczi a =E9c= rit : > > > > Hi Benoit, > > > > Kevin and I had a chance to chat face-to-face and we discussed wh= at > > > > concrete changes are necessary to merge quorum (without solving a= ll the > > > > other block layers problems at once). > > > >=20 > > > > I think quorum could be merged relatively quickly (and without ma= ssive > > > > BlockFilter investments) by changing the following: > > > >=20 > > > > 1. Defining children on the command-line > > > >=20 > > > > Existing "filter" drivers use the protocol filename to embed thei= r > > > > children, for example the blkverify driver. This is a big hack b= ecause > > > > we have no proper syntax or escaping for the embedded drive defin= itions > > > > in the file=3D option. > > > >=20 > > > > This was one of the main arguments against merging quorum. Now t= hat > > > > Kevin has implemented driver-specific open options (see > > > > block/qcow2.c:qcow2_runtime_opts), it is possible for the quorum = driver > > > > to open children specific on the command-line: > > > >=20 > > > > -drive if=3Dnone,file.driver=3Dquorum,format=3Draw,\ > > > > file.children0.file=3D/nfs1/test.qcow2,\ > > > > file.children1.file=3D/nfs2/test.qcow2,\ > > > > file.children2.file=3D/nfs3/test.qcow2 >=20 > By the way, I think he concrete syntax might have to be a bit different > so it can be mapped to QAPI for blockdev-add. I think we'll want to use > a JSON list for the children; a mapping to QDict and to the command lin= e > is yet to be implemented I guess. Hi, Just to make sure I'll code the right thing; is the following correct ? -drive if=3Dnone,file.driver=3Dquorum,format=3Draw,\ file.children=3D[/nfs1/test.qcow2, /nfs2/test.qcow2, /nfs3/test.qc= ow2], \ file.vote_threshold=3D2 Best regards Beno=EEt