From: Stefan Hajnoczi <stefanha@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
Kevin Wolf <kwolf@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] block: Fix compiler warning (-Werror=uninitialized)
Date: Thu, 19 Sep 2013 16:44:34 +0200 [thread overview]
Message-ID: <20130919144434.GQ22814@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1379436196-27506-1-git-send-email-sw@weilnetz.de>
On Tue, Sep 17, 2013 at 06:43:16PM +0200, Stefan Weil wrote:
> The patch fixes a warning from gcc (Debian 4.6.3-14+rpi1) 4.6.3:
>
> block/stream.c:141:22: error:
> ‘copy’ may be used uninitialized in this function [-Werror=uninitialized]
>
> This is not a real bug - a better compiler would not complain.
>
> Now 'copy' has always a defined value, so the check for ret >= 0
> can be removed.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> block/stream.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
next prev parent reply other threads:[~2013-09-19 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 16:43 [Qemu-devel] [PATCH] block: Fix compiler warning (-Werror=uninitialized) Stefan Weil
2013-09-19 14:44 ` Stefan Hajnoczi [this message]
2013-09-19 16:59 ` Andreas Färber
2013-09-19 17:22 ` Paolo Bonzini
2013-09-20 10:42 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130919144434.GQ22814@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).