From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMfTG-0008Rt-EQ for qemu-devel@nongnu.org; Thu, 19 Sep 2013 10:44:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMfTB-0003qw-Gf for qemu-devel@nongnu.org; Thu, 19 Sep 2013 10:44:42 -0400 Date: Thu, 19 Sep 2013 16:44:34 +0200 From: Stefan Hajnoczi Message-ID: <20130919144434.GQ22814@stefanha-thinkpad.redhat.com> References: <1379436196-27506-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1379436196-27506-1-git-send-email-sw@weilnetz.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] block: Fix compiler warning (-Werror=uninitialized) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-trivial , Kevin Wolf , qemu-devel On Tue, Sep 17, 2013 at 06:43:16PM +0200, Stefan Weil wrote: > The patch fixes a warning from gcc (Debian 4.6.3-14+rpi1) 4.6.3: >=20 > block/stream.c:141:22: error: > =E2=80=98copy=E2=80=99 may be used uninitialized in this function [-Wer= ror=3Duninitialized] >=20 > This is not a real bug - a better compiler would not complain. >=20 > Now 'copy' has always a defined value, so the check for ret >=3D 0 > can be removed. >=20 > Signed-off-by: Stefan Weil > --- > block/stream.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan