qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Benoît Canet" <benoit.canet@irqsave.net>,
	qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
	"Stefan Hajnoczi" <stefanha@gmail.com>
Subject: Re: [Qemu-devel] Merging the quorum block driver
Date: Thu, 19 Sep 2013 16:05:17 +0100	[thread overview]
Message-ID: <20130919150517.GB19543@redhat.com> (raw)
In-Reply-To: <523B0F7B.5060204@redhat.com>

On Thu, Sep 19, 2013 at 08:51:39AM -0600, Eric Blake wrote:
> On 09/19/2013 07:21 AM, Kevin Wolf wrote:
> 
> > 
> > I was thinking more along the lines of:
> > 
> >     -drive if=none,file.driver=quorum,format=raw,\
> >            file.children[0].file.filename=/nfs1/test.qcow2, \
> 
> Note that this requires shell quoting to protect you from globbing
> changing the argv handed to qemu based on an (unusual) file name in the
> current directory.  Not necessarily the end of the world (someone like
> libvirt that uses exec rather than a shell command line isn't bothered
> by it, and the command line is so long that most users will not be
> typing it directly), but worth thinking about whether we can come up
> with an alternate syntax that doesn't require shell quoting.  (As is,
> your use of \-newline and whitespace is not quite right for how the
> actual command line would appear; but it does make discussion easier in
> the meantime)

Just don't use brackets - use a . for the array index separator too
eg

 -drive if=none,file.driver=quorum,format=raw,\
    file.children.0.file.filename=foo,\
    file.children.1.file.filename=bar,\
    file.children.2.file.filename=wiz,\

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

      reply	other threads:[~2013-09-19 15:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-17 12:44 [Qemu-devel] Merging the quorum block driver Stefan Hajnoczi
2013-09-17 16:13 ` Benoît Canet
2013-09-18 15:05 ` Benoît Canet
2013-09-19  8:26   ` Stefan Hajnoczi
2013-09-19  8:57     ` Kevin Wolf
2013-09-19 12:55       ` Benoît Canet
2013-09-19 13:21         ` Kevin Wolf
2013-09-19 13:38           ` Benoît Canet
2013-09-19 14:23             ` Kevin Wolf
2013-09-20 12:08               ` Benoît Canet
2013-09-20 14:26                 ` Kevin Wolf
2013-09-19 14:51           ` Eric Blake
2013-09-19 15:05             ` Daniel P. Berrange [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130919150517.GB19543@redhat.com \
    --to=berrange@redhat.com \
    --cc=benoit.canet@irqsave.net \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).