From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMfnP-0000uF-NM for qemu-devel@nongnu.org; Thu, 19 Sep 2013 11:05:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMfnL-00027D-SC for qemu-devel@nongnu.org; Thu, 19 Sep 2013 11:05:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMfnL-000272-J5 for qemu-devel@nongnu.org; Thu, 19 Sep 2013 11:05:27 -0400 Date: Thu, 19 Sep 2013 16:05:17 +0100 From: "Daniel P. Berrange" Message-ID: <20130919150517.GB19543@redhat.com> References: <20130917124413.GA822@stefanha-thinkpad.str.redhat.com> <20130918150527.GA5025@irqsave.net> <20130919082653.GC22814@stefanha-thinkpad.redhat.com> <20130919085750.GA3631@dhcp-200-207.str.redhat.com> <20130919125536.GA12498@irqsave.net> <20130919132146.GB3631@dhcp-200-207.str.redhat.com> <523B0F7B.5060204@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <523B0F7B.5060204@redhat.com> Subject: Re: [Qemu-devel] Merging the quorum block driver Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , =?utf-8?Q?Beno=C3=AEt?= Canet , qemu-devel@nongnu.org, Stefan Hajnoczi , Stefan Hajnoczi On Thu, Sep 19, 2013 at 08:51:39AM -0600, Eric Blake wrote: > On 09/19/2013 07:21 AM, Kevin Wolf wrote: > > > > > I was thinking more along the lines of: > > > > -drive if=none,file.driver=quorum,format=raw,\ > > file.children[0].file.filename=/nfs1/test.qcow2, \ > > Note that this requires shell quoting to protect you from globbing > changing the argv handed to qemu based on an (unusual) file name in the > current directory. Not necessarily the end of the world (someone like > libvirt that uses exec rather than a shell command line isn't bothered > by it, and the command line is so long that most users will not be > typing it directly), but worth thinking about whether we can come up > with an alternate syntax that doesn't require shell quoting. (As is, > your use of \-newline and whitespace is not quite right for how the > actual command line would appear; but it does make discussion easier in > the meantime) Just don't use brackets - use a . for the array index separator too eg -drive if=none,file.driver=quorum,format=raw,\ file.children.0.file.filename=foo,\ file.children.1.file.filename=bar,\ file.children.2.file.filename=wiz,\ Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|